From: Thomas Huth <thuth@redhat.com>
To: Fabiano Rosas <farosas@suse.de>, qemu-devel@nongnu.org
Cc: Laurent Vivier <lvivier@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v2 06/12] test/qtest: Fix coding style in device-plug-test.c
Date: Thu, 9 Feb 2023 09:08:20 +0100 [thread overview]
Message-ID: <83e17f5a-ff9a-7fbd-417c-b0918368bf4f@redhat.com> (raw)
In-Reply-To: <20230208194700.11035-7-farosas@suse.de>
On 08/02/2023 20.46, Fabiano Rosas wrote:
> We should not mix declarations and statements in QEMU code.
>
> Signed-off-by: Fabiano Rosas <farosas@suse.de>
> ---
> tests/qtest/device-plug-test.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2023-02-09 8:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230208194700.11035-1-farosas@suse.de>
2023-02-08 19:46 ` [PATCH v2 01/12] tests/qtest: Skip PXE tests for missing devices Fabiano Rosas
2023-02-08 19:46 ` [PATCH v2 02/12] tests/qtest: Do not run lsi53c895a test if device is not present Fabiano Rosas
2023-02-08 19:46 ` [PATCH v2 08/12] tests/qtest: drive_del-test: Skip tests that require missing devices Fabiano Rosas
2023-02-09 8:12 ` Thomas Huth
[not found] ` <20230208194700.11035-4-farosas@suse.de>
2023-02-09 8:00 ` [PATCH v2 03/12] tests/qtest: Add dependence on PCIE_PORT for virtio-net-failover.c Thomas Huth
[not found] ` <20230208194700.11035-5-farosas@suse.de>
2023-02-09 8:06 ` [PATCH v2 04/12] tests/qtest: Don't build virtio-serial-test.c if device not present Thomas Huth
[not found] ` <20230208194700.11035-7-farosas@suse.de>
2023-02-09 8:08 ` Thomas Huth [this message]
[not found] ` <20230208194700.11035-8-farosas@suse.de>
2023-02-09 8:11 ` [PATCH v2 07/12] tests/qtest: Skip unplug tests that use missing devices Thomas Huth
[not found] ` <20230208194700.11035-11-farosas@suse.de>
2023-02-09 8:46 ` [PATCH v2 10/12] tests/qtest: Do not include hexloader-test if loader device is not present Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83e17f5a-ff9a-7fbd-417c-b0918368bf4f@redhat.com \
--to=thuth@redhat.com \
--cc=farosas@suse.de \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).