Re: [PATCH] host-utils: Drop workaround for buggy Apple Clang __builtin_subcll()

[Richard Henderson <richard.henderson@linaro.org>]

On 7/14/25 08:50, Peter Maydell wrote:
> In commit b0438861efe ("host-utils: Avoid using __builtin_subcll on
> buggy versions of Apple Clang") we added a workaround for a bug in
> Apple Clang 14 where its __builtin_subcll() implementation was wrong.
> This bug was only present in Apple Clang 14, not in upstream clang,
> and is not present in Apple Clang versions 15 and newer.
> 
> Since commit 4e035201 we have required at least Apple Clang 15, so we
> no longer build with the buggy versions.  We can therefore drop the
> workaround. This is effectively a revert of b0438861efe.
> 
> This should not be backported to stable branches, which may still
> need to support Apple Clang 14.
> 
> Resolves:https://gitlab.com/qemu-project/qemu/-/issues/3030
> Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
> ---
>   include/qemu/compiler.h   | 13 -------------
>   include/qemu/host-utils.h |  2 +-
>   2 files changed, 1 insertion(+), 14 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

Commit 4e035201 was in 9.2.0, but indeed there's no point in backporting to any stable branch.


r~