From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40935)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1bq2gG-0003QP-U7
	for qemu-devel@nongnu.org; Fri, 30 Sep 2016 14:37:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1bq2gF-0004X8-0H
	for qemu-devel@nongnu.org; Fri, 30 Sep 2016 14:37:07 -0400
References: <1475230780-8669-1-git-send-email-edgar.iglesias@gmail.com>
	<4496a78f-e527-fae4-0bc5-a9f1c0d5c997@redhat.com>
	<20160930104909.GD9606@toto>
	<CAFEAcA_6VUj5VDNTiRz1-hST=-AQD+tOneMy1-x7qYjt68YLFQ@mail.gmail.com>
From: Eric Blake <eblake@redhat.com>
Message-ID: <83fc8d2a-2dd6-261c-ffdb-dda8881a5c25@redhat.com>
Date: Fri, 30 Sep 2016 13:36:59 -0500
MIME-Version: 1.0
In-Reply-To: <CAFEAcA_6VUj5VDNTiRz1-hST=-AQD+tOneMy1-x7qYjt68YLFQ@mail.gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature";
	boundary="OvFTxCd0GCkXD9VALLGUfTFfLXWNX0Ppu"
Subject: Re: [Qemu-devel] [PATCH v1 1/1] target-arm: A64: Fix decoding of
 iss_sf in disas_ld_lit
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Cc: Edgar Iglesias <edgar.iglesias@xilinx.com>, Thomas Huth <thuth@redhat.com>, qemu-arm <qemu-arm@nongnu.org>, QEMU Developers <qemu-devel@nongnu.org>

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--OvFTxCd0GCkXD9VALLGUfTFfLXWNX0Ppu
From: Eric Blake <eblake@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>,
 "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Cc: Edgar Iglesias <edgar.iglesias@xilinx.com>, Thomas Huth
 <thuth@redhat.com>, qemu-arm <qemu-arm@nongnu.org>,
 QEMU Developers <qemu-devel@nongnu.org>
Message-ID: <83fc8d2a-2dd6-261c-ffdb-dda8881a5c25@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v1 1/1] target-arm: A64: Fix decoding of
 iss_sf in disas_ld_lit
References: <1475230780-8669-1-git-send-email-edgar.iglesias@gmail.com>
 <4496a78f-e527-fae4-0bc5-a9f1c0d5c997@redhat.com>
 <20160930104909.GD9606@toto>
 <CAFEAcA_6VUj5VDNTiRz1-hST=-AQD+tOneMy1-x7qYjt68YLFQ@mail.gmail.com>
In-Reply-To: <CAFEAcA_6VUj5VDNTiRz1-hST=-AQD+tOneMy1-x7qYjt68YLFQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 09/30/2016 12:34 PM, Peter Maydell wrote:
>>>> +        bool iss_sf =3D opc =3D=3D 0 ? false : true;

Feels like a double negative.

>>>
>>> You could simplify that to:
>>>
>>>       bool iss_sf =3D !(opc =3D=3D 0);
>>
>> I don't really see how that is simpler/clearer.
>>
>> I considered:
>> bool iss_sf =3D opc !=3D 0;

Or even shorter:

bool iss_sf =3D !opc;

--=20
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


--OvFTxCd0GCkXD9VALLGUfTFfLXWNX0Ppu
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCAAGBQJX7rDLAAoJEKeha0olJ0NqmGcH/j9WW7QdREPwvLuO2WDTM1kx
6Jq1y9XngSlfwDTJd9NKE5jCaTfdBzGfgubkyg/JxYXVhzbHs73+QcU009KaUrdd
yB0cN03Xx3I5oqUz4LtBeBdnX1B1DFeI958WY1pEbHwbv3VCMkfLcjMB8WE20OKb
8V9Jf5YtR7tXKHOvWVYWat8qXdRd/DeaY3XqKjdjWSf3U3R0W8P851hxUg8xd9TB
q+qHMKwL87e2P0nKYE6dzvNTd8dFtcSHn17EYhCxlKlxrVkY5HDZXIJEeQNu3aTD
MnCCfRVFc/UzyoFQtwUMpJdZLWW9p9lT6aUmEVkEWkQSNBjo6XB9j4J4kDmNaAg=
=M1y5
-----END PGP SIGNATURE-----

--OvFTxCd0GCkXD9VALLGUfTFfLXWNX0Ppu--