From: Paolo Bonzini <pbonzini@redhat.com>
To: Thomas Huth <thuth@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PULL 0/3] Usb 20170929 patches
Date: Wed, 4 Oct 2017 11:58:40 +0200 [thread overview]
Message-ID: <84018e17-ecf2-71ff-b70e-0f53c3464e68@redhat.com> (raw)
In-Reply-To: <9d566b88-7991-b9f4-8b73-737a99d3ac6d@redhat.com>
On 04/10/2017 11:37, Thomas Huth wrote:
> Ah, deja vu. I think you've now run into the problem that I had with my
> patch, too - see:
>
> https://lists.gnu.org/archive/html/qemu-devel/2017-09/msg01875.html
> https://lists.gnu.org/archive/html/qemu-devel/2017-09/msg02082.html
>
> I think this is a race condition when building with "make -j" in
> parallel. Just add a line like this and you should be fine:
>
> common-obj-$(CONFIG_ALL) += host-stub.o
That's correct! Maybe it should be documented in build-system.txt.
It's basically an optimization, CONFIG_ALL is used when some stubs are
not used in all subtargets but you still want to build them once-only.
Then the toplevel Makefile will typically see the configuration symbol
as defined (because it operates on the union of all targets'
configuration symbols), and will skip builting the "stubs" file. Using
CONFIG_ALL for the stubs file ensures that the object file is available
before recursing.
Paolo
prev parent reply other threads:[~2017-10-04 9:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-29 11:00 [Qemu-devel] [PULL 0/3] Usb 20170929 patches Gerd Hoffmann
2017-09-29 11:00 ` [Qemu-devel] [PULL 1/3] hw/usb/bus: Remove bad object_unparent() from usb_try_create_simple() Gerd Hoffmann
2017-09-29 11:00 ` [Qemu-devel] [PULL 2/3] usb: fix libusb config variable name Gerd Hoffmann
2017-09-29 11:00 ` [Qemu-devel] [PULL 3/3] usb: Use angle brackets for cacard include directive Gerd Hoffmann
2017-10-03 14:08 ` [Qemu-devel] [PULL 0/3] Usb 20170929 patches Peter Maydell
2017-10-04 8:43 ` Gerd Hoffmann
2017-10-04 9:37 ` Thomas Huth
2017-10-04 9:50 ` Gerd Hoffmann
2017-10-04 9:59 ` Paolo Bonzini
2017-10-04 9:58 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84018e17-ecf2-71ff-b70e-0f53c3464e68@redhat.com \
--to=pbonzini@redhat.com \
--cc=kraxel@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).