From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB278C4741F for ; Thu, 1 Oct 2020 15:23:07 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 747D920672 for ; Thu, 1 Oct 2020 15:23:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="pJm8Ilse" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 747D920672 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:48086 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kO0QE-0008Oq-Eg for qemu-devel@archiver.kernel.org; Thu, 01 Oct 2020 11:23:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52024) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kO0L6-0000Zw-4j for qemu-devel@nongnu.org; Thu, 01 Oct 2020 11:17:48 -0400 Received: from mail-oo1-xc2c.google.com ([2607:f8b0:4864:20::c2c]:41790) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kO0L4-0008OF-Cy for qemu-devel@nongnu.org; Thu, 01 Oct 2020 11:17:47 -0400 Received: by mail-oo1-xc2c.google.com with SMTP id t3so1561673ook.8 for ; Thu, 01 Oct 2020 08:17:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=e6hpdWWJtuusPfDjuvPD2LTEmj0bTNhgIzy8RUPrr2A=; b=pJm8IlseG0MRDxeYCTyaLPV5FytsefXzE2xXqDaC3tj9Zy6tVMmyPJ0IMRrlP5Nnkv StsKa3lr8Elp5rYbxeH4R9ILj/XxUYbKJXzLoTY7ppaeSMFlGd1/LPEZDx3XT3OSKVLU uoinpeq/VFmiER4qZd2TMcpdrEz2F9SUmmwzdfRw3uPCNjcA2Rfe7Poq7JhoGFNgOO67 hjflRsob+buBCY75EZm6V3AyQGMC4Rbo0S4CCBO3tH2ik7F3uaf388w08cA++sJ1PQ1O wNPeoae0ADhCuyvWrLaikJqwIIUkj+hyfAZOjbUAtPnRMq/cF6ogUqm1D874BcqOpobs 8iIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=e6hpdWWJtuusPfDjuvPD2LTEmj0bTNhgIzy8RUPrr2A=; b=oaItc8BkPYRKx272dhqJdasMfvNKu/mX7IDVtZKu+6rdDYP0l+hL0v9Y6oTCeck8x6 38XlLlDP9BHj34I7CDS8QN3Shj/CJL5aVNWHx4nbCHsppjADwM+TQsyWqdShwnfciGlE kr6+nXRHMKLCeNqVwdQGrTRm2j/QVKwPUcHs6mioVXIb71AkFZaGQzalGQ6QIP/Bs9/6 8q0q6KnNeNt9wyoMvm8tx4+82yFwlwmQQg3m2ncnBrPDjT2+/Wh4iqM4o+yHe4qcLO5b l1VqI6rV1l4G2sltV60mlCnKOKJDfJw9z4JE/sGGK/r1yEfwhZTE6tHdfoB3YlN5ALmm 1M3A== X-Gm-Message-State: AOAM530bkFlkt+rQg/wkGk/1Jzp6K69dQP1ZBo3NDYOAXu13gmhsY8SA EDjkk696m+imYuneBkg7LPFDgw== X-Google-Smtp-Source: ABdhPJwIPBf48C5NgKNE5oWOuNJpImfId4qbVa3w7ReIED12UTR+jtDPCBDCuwgQ2sp+nvJu1kzY8g== X-Received: by 2002:a4a:e689:: with SMTP id u9mr6105843oot.52.1601565464859; Thu, 01 Oct 2020 08:17:44 -0700 (PDT) Received: from [10.10.73.179] (fixed-187-189-51-144.totalplay.net. [187.189.51.144]) by smtp.gmail.com with ESMTPSA id r3sm1345125ooo.16.2020.10.01.08.17.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Oct 2020 08:17:43 -0700 (PDT) Subject: Re: [PATCH v1 02/20] s390x/tcg: Implement VECTOR BIT PERMUTE To: David Hildenbrand , qemu-devel@nongnu.org References: <20200930145523.71087-1-david@redhat.com> <20200930145523.71087-3-david@redhat.com> From: Richard Henderson Message-ID: <84292bd0-7751-1cc8-afc8-83b40d89a754@linaro.org> Date: Thu, 1 Oct 2020 10:17:40 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200930145523.71087-3-david@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::c2c; envelope-from=richard.henderson@linaro.org; helo=mail-oo1-xc2c.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -23 X-Spam_score: -2.4 X-Spam_bar: -- X-Spam_report: (-2.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.26, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-s390x@nongnu.org, Cornelia Huck , Thomas Huth Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 9/30/20 9:55 AM, David Hildenbrand wrote: > + bit = !!(s390_vec_read_element8(v2, bit_nr / 8) & > + (0x80 >> (bit_nr % 8))); I think this would be clearer as bit = (s390_vec_read_element8(v2, bit_nr / 8) >> (7 - (bit_nr % 8))) & 1; Otherwise, Reviewed-by: Richard Henderson r~