From: Peter Chubb <peter.chubb@nicta.com.au>
To: Stefan Weil <sw@weilnetz.de>
Cc: Peter Chubb <peter.chubb@nicta.com.au>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] i.MX31: Fix PRCS bit test
Date: Mon, 10 Jun 2013 09:20:47 +1000 [thread overview]
Message-ID: <8438sqlvlc.wl%peter@chubb.wattle.id.au> (raw)
In-Reply-To: <1370810662-32320-1-git-send-email-sw@weilnetz.de>
>>>>> "Stefan" == Stefan Weil <sw@weilnetz.de> writes:
Stefan> cppcheck detected a condition which was always false.
Stefan> According to the MCIMX31 Reference Manual, the PRCS bits have
Stefan> to be 01 to select the Frequency Pre-Multiplier (FPM). PRCS
Stefan> uses bits 1 and 2, so we have to test for 2.
Good catch. I hate hard coded constants, they're so easy to get wrong!
Stefan> Signed-off-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Peter Chubb <peter.chubb@nicta.com.au>
--
Dr Peter Chubb peter.chubb AT nicta.com.au
http://www.ssrg.nicta.com.au Software Systems Research Group/NICTA
next prev parent reply other threads:[~2013-06-09 23:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-09 20:44 [Qemu-devel] [PATCH] i.MX31: Fix PRCS bit test Stefan Weil
2013-06-09 23:20 ` Peter Chubb [this message]
2013-06-25 17:43 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8438sqlvlc.wl%peter@chubb.wattle.id.au \
--to=peter.chubb@nicta.com.au \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).