From: Cleber Rosa <crosa@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Eduardo Habkost <ehabkost@redhat.com>,
Alistair Francis <alistair@alistair23.me>,
qemu-devel@nongnu.org, Subbaraya Sundeep <sundeep.lkml@gmail.com>,
qemu-arm@nongnu.org, Caio Carrara <ccarrara@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/2] BootLinuxConsoleTest: Do not log empty lines
Date: Thu, 23 May 2019 09:48:52 -0400 (EDT) [thread overview]
Message-ID: <843987408.24357253.1558619332877.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20190520220635.10961-2-f4bug@amsat.org>
----- Original Message -----
> From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
> To: qemu-devel@nongnu.org
> Cc: "Eduardo Habkost" <ehabkost@redhat.com>, "Caio Carrara" <ccarrara@redhat.com>, "Alistair Francis"
> <alistair@alistair23.me>, "Subbaraya Sundeep" <sundeep.lkml@gmail.com>, qemu-arm@nongnu.org, "Cleber Rosa"
> <crosa@redhat.com>, "Peter Maydell" <peter.maydell@linaro.org>, "Philippe Mathieu-Daudé" <f4bug@amsat.org>
> Sent: Monday, May 20, 2019 6:06:34 PM
> Subject: [PATCH 1/2] BootLinuxConsoleTest: Do not log empty lines
>
> Avoid to log empty lines in console debug logs.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> tests/acceptance/boot_linux_console.py | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/tests/acceptance/boot_linux_console.py
> b/tests/acceptance/boot_linux_console.py
> index d5c500ea30..f593f3858e 100644
> --- a/tests/acceptance/boot_linux_console.py
> +++ b/tests/acceptance/boot_linux_console.py
> @@ -37,8 +37,10 @@ class BootLinuxConsole(Test):
> console = self.vm.console_socket.makefile()
> console_logger = logging.getLogger('console')
> while True:
> - msg = console.readline()
> - console_logger.debug(msg.strip())
> + msg = console.readline().strip()
> + if not msg:
> + continue
> + console_logger.debug(msg)
> if success_message in msg:
> break
> if failure_message in msg:
> --
> 2.19.1
>
>
Reviewed-by: Cleber Rosa <crosa@redhat.com>
next prev parent reply other threads:[~2019-05-23 13:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-20 22:06 [Qemu-devel] [PATCH 0/2] tests: Avocado-test for the SmartFusion2 board Philippe Mathieu-Daudé
2019-05-20 22:06 ` [Qemu-devel] [PATCH 1/2] BootLinuxConsoleTest: Do not log empty lines Philippe Mathieu-Daudé
2019-05-20 22:34 ` Alistair Francis
2019-05-23 13:48 ` Cleber Rosa [this message]
2019-06-05 15:57 ` Cleber Rosa
2019-06-05 20:52 ` Aleksandar Markovic
2019-05-20 22:06 ` [Qemu-devel] [PATCH 2/2] BootLinuxConsoleTest: Test the SmartFusion2 board Philippe Mathieu-Daudé
2019-05-20 22:35 ` Alistair Francis
2019-05-23 14:07 ` Cleber Rosa
2019-06-05 16:06 ` Cleber Rosa
2019-06-05 20:43 ` Eduardo Habkost
2019-06-06 18:29 ` Cleber Rosa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=843987408.24357253.1558619332877.JavaMail.zimbra@redhat.com \
--to=crosa@redhat.com \
--cc=alistair@alistair23.me \
--cc=ccarrara@redhat.com \
--cc=ehabkost@redhat.com \
--cc=f4bug@amsat.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=sundeep.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).