qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: Huacai Chen <chenhuacai@kernel.org>,
	Bernhard Beschow <shentey@gmail.com>,
	Jiaxun Yang <jiaxun.yang@flygoat.com>
Subject: Re: [PATCH 8/8] hw/mips/fuloong2e: Open code bonito_init()
Date: Fri, 6 Jan 2023 11:16:49 -0800	[thread overview]
Message-ID: <8446ae9b-edda-8e09-6e02-aa4a14c16eb8@linaro.org> (raw)
In-Reply-To: <20230105130710.49264-9-philmd@linaro.org>

On 1/5/23 05:07, Philippe Mathieu-Daudé wrote:
> This helper is trivial and is called once, directly open-code it.
> 
> Signed-off-by: Philippe Mathieu-Daudé<philmd@linaro.org>
> ---
>   hw/mips/fuloong2e.c    |  6 +++++-
>   hw/pci-host/bonito.c   | 15 ---------------
>   include/hw/mips/mips.h |  3 ---
>   3 files changed, 5 insertions(+), 19 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~


  reply	other threads:[~2023-01-06 19:17 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-05 13:07 [PATCH 0/8] hw/pci-host/bonito: Housekeeping Philippe Mathieu-Daudé
2023-01-05 13:07 ` [PATCH 1/8] hw/pci-host/bonito: Convert to 3-phase reset Philippe Mathieu-Daudé
2023-01-06 18:43   ` Richard Henderson
2023-01-05 13:07 ` [PATCH 2/8] hw/pci-host/bonito: Use 'bonito_host' for PCI host bridge code Philippe Mathieu-Daudé
2023-01-06 18:43   ` Richard Henderson
2023-01-05 13:07 ` [PATCH 3/8] hw/pci-host/bonito: Use 'bonito_pci' for PCI function #0 code Philippe Mathieu-Daudé
2023-01-06 18:48   ` Richard Henderson
2023-01-05 13:07 ` [PATCH 4/8] hw/pci-host/bonito: Set reference using object_property_add_const_link() Philippe Mathieu-Daudé
2023-01-06 18:49   ` Richard Henderson
2023-01-05 13:07 ` [PATCH 5/8] hw/pci-host/bonito: Create PCI function #0 in bridge realize() handler Philippe Mathieu-Daudé
2023-01-06 18:57   ` Richard Henderson
2023-01-05 13:07 ` [PATCH 6/8] hw/pci-host/bonito: Sysbus'ify outgoing IRQ Philippe Mathieu-Daudé
2023-01-06 19:14   ` Richard Henderson
2023-01-05 13:07 ` [PATCH 7/8] hw/pci-host/bonito: Declare TYPE_BONITO_PCI_HOST_BRIDGE in header Philippe Mathieu-Daudé
2023-01-06 19:15   ` Richard Henderson
2023-01-05 13:07 ` [PATCH 8/8] hw/mips/fuloong2e: Open code bonito_init() Philippe Mathieu-Daudé
2023-01-06 19:16   ` Richard Henderson [this message]
2023-01-13  8:11 ` [PATCH 0/8] hw/pci-host/bonito: Housekeeping Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8446ae9b-edda-8e09-6e02-aa4a14c16eb8@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=chenhuacai@kernel.org \
    --cc=jiaxun.yang@flygoat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=shentey@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).