From: Maxim Levitsky <mlevitsk@redhat.com>
To: Max Reitz <mreitz@redhat.com>, qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH v2 0/5] block: Generic file creation fallback
Date: Wed, 19 Feb 2020 12:47:15 +0200 [thread overview]
Message-ID: <845cac1792e49a1c6dfab6767cb4f2e99131679d.camel@redhat.com> (raw)
In-Reply-To: <07edfa0c-25af-e519-eb41-5bcda107438e@redhat.com>
On Wed, 2020-02-19 at 11:38 +0100, Max Reitz wrote:
> On 22.01.20 17:45, Max Reitz wrote:
> > Hi,
> >
> > As version 1, this series adds a fallback path for creating files (on
> > the protocol layer) if the protocol driver does not support file
> > creation, but the file already exists.
> >
> >
> > Branch: https://github.com/XanClic/qemu.git skip-proto-create-v2
> > Branch: https://git.xanclic.moe/XanClic/qemu.git skip-proto-create-v2
> >
> >
> > v2:
> > - Drop blk_truncate_for_formatting(): It doesn’t make sense to introduce
> > this function any more after 26536c7fc25917d1bd13781f81fe3ab039643bff
> > (“block: Do not truncate file node when formatting”), because we’d
> > only use it in bdrv_create_file_fallback().
> > Thus, it makes more sense to create special helper functions
> > specifically for bdrv_create_file_fallback().
> >
> > - Thus, dropped patches 2 and 3.
> >
> > - And changed patch 4 to include those helper functions.
> >
> > - Rebased, which was a bit of a pain.
>
> Thanks for the reviews, added a note to the new test why the second case
> is expected to fail (as requested by Maxim), and applied the series to
> my block branch:
>
> https://git.xanclic.moe/XanClic/qemu/commits/branch/block
>
> Max
>
Thank you too!
Best regards,
Maxim Levitsky
prev parent reply other threads:[~2020-02-19 10:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-22 16:45 [PATCH v2 0/5] block: Generic file creation fallback Max Reitz
2020-01-22 16:45 ` [PATCH v2 1/5] block/nbd: Fix hang in .bdrv_close() Max Reitz
2020-01-22 18:55 ` Eric Blake
2020-01-23 22:54 ` Maxim Levitsky
2020-01-22 16:45 ` [PATCH v2 2/5] block: Generic file creation fallback Max Reitz
2020-01-23 22:58 ` Maxim Levitsky
2020-01-22 16:45 ` [PATCH v2 3/5] file-posix: Drop hdev_co_create_opts() Max Reitz
2020-01-22 16:45 ` [PATCH v2 4/5] iscsi: Drop iscsi_co_create_opts() Max Reitz
2020-01-22 16:45 ` [PATCH v2 5/5] iotests: Add test for image creation fallback Max Reitz
2020-01-22 19:05 ` Eric Blake
2020-01-23 22:59 ` Maxim Levitsky
2020-02-19 10:38 ` [PATCH v2 0/5] block: Generic file " Max Reitz
2020-02-19 10:47 ` Maxim Levitsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=845cac1792e49a1c6dfab6767cb4f2e99131679d.camel@redhat.com \
--to=mlevitsk@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).