From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:38338)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1TTunL-0007dp-Aw
	for qemu-devel@nongnu.org; Thu, 01 Nov 2012 09:26:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1TTunK-00045O-5M
	for qemu-devel@nongnu.org; Thu, 01 Nov 2012 09:26:51 -0400
Received: from mx3-phx2.redhat.com ([209.132.183.24]:44061)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1TTunJ-00045J-Rk
	for qemu-devel@nongnu.org; Thu, 01 Nov 2012 09:26:50 -0400
Date: Thu, 1 Nov 2012 09:26:48 -0400 (EDT)
From: Alon Levy <alevy@redhat.com>
Message-ID: <846964650.25379532.1351776408680.JavaMail.root@redhat.com>
In-Reply-To: <509277C7.6000301@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] ui/spice: support websockets ports
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org

> On 10/19/12 13:52, Alon Levy wrote:
> > Signed-off-by: Alon Levy <alevy@redhat.com>
> > ---
> > Spice package is not yet available, I assumed it will be the next
> > version, 0.12.1, for the added API spice_server_set_ws_ports.
> > Patches are on spice-devel and git is at
> > http://cgit.freedesktop.org/~alon/spice master branch
> > (db5817a059d640fb4ca21740e1362fc6c3e98765)
> 
> What is the state of this? Committed to spice-server meanwhile?

No, It doesn't work well enough, and I don't have time to fix it.

> 
> > --- a/roms/openbios
> > +++ b/roms/openbios
> > @@ -1 +1 @@
> > -Subproject commit f095c858136896d236931357b8d597f407286f71
> > +Subproject commit d1d2787f87167edf487a60e61b9168514d5a7434
> 
> Hmm?

Yes, my bad.

> 
> > diff --git a/ui/spice-core.c b/ui/spice-core.c
> > index 5147365..190b14d 100644
> > --- a/ui/spice-core.c
> > +++ b/ui/spice-core.c
> > @@ -542,6 +542,14 @@ static void vm_change_state_handler(void
> > *opaque, int running,
> >      }
> >  }
> >  
> > +static void validate_port(int port, const char *port_name)
> > +{
> > +    if (port < 0 || port > 65535) {
> > +        error_report("spice %s is out of range", port_name);
> > +        exit(1);
> > +    }
> > +}
> 
> That should go as separate patch.

OK.

> 
> cheers.
>   Gerd
> 
>