From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A1DAC4360C for ; Sun, 29 Sep 2019 16:35:59 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C67C6217F5 for ; Sun, 29 Sep 2019 16:35:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C67C6217F5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:40962 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iEcAv-0002nJ-2u for qemu-devel@archiver.kernel.org; Sun, 29 Sep 2019 12:35:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54983) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iEc7z-0000mZ-F7 for qemu-devel@nongnu.org; Sun, 29 Sep 2019 12:32:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iEc7y-00033d-Bl for qemu-devel@nongnu.org; Sun, 29 Sep 2019 12:32:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36250) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iEc7t-0002yp-Uv; Sun, 29 Sep 2019 12:32:50 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 370ED308A9E0; Sun, 29 Sep 2019 16:32:49 +0000 (UTC) Received: from maximlenovopc.usersys.redhat.com (unknown [10.35.206.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id F0E595D9C9; Sun, 29 Sep 2019 16:32:47 +0000 (UTC) Message-ID: <846ad1f0f54e677486f36fb7c6f4ebcf97af3b15.camel@redhat.com> Subject: Re: [PATCH 06/18] iotests: Inject space into -ocompat=0.10 in 051 From: Maxim Levitsky To: Max Reitz , qemu-block@nongnu.org Date: Sun, 29 Sep 2019 19:32:47 +0300 In-Reply-To: <20190927094242.11152-7-mreitz@redhat.com> References: <20190927094242.11152-1-mreitz@redhat.com> <20190927094242.11152-7-mreitz@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Sun, 29 Sep 2019 16:32:49 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, 2019-09-27 at 11:42 +0200, Max Reitz wrote: > It did not matter before, but now that _make_test_img understands -o, we > should use it properly here. > > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/051 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/qemu-iotests/051 b/tests/qemu-iotests/051 > index 53bcdbc911..9cd1d60d45 100755 > --- a/tests/qemu-iotests/051 > +++ b/tests/qemu-iotests/051 > @@ -157,7 +157,7 @@ echo > echo === With version 2 images enabling lazy refcounts must fail === > echo > > -_make_test_img -ocompat=0.10 $size > +_make_test_img -o compat=0.10 $size > > run_qemu -drive file="$TEST_IMG",format=qcow2,lazy-refcounts=on > run_qemu -drive file="$TEST_IMG",format=qcow2,lazy-refcounts=off Reviewed-by: Maxim Levitsky