From: Paolo Bonzini <pbonzini@redhat.com>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: alex.bennee@linaro.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [RFC 0/3] Move notdirty handling to cputlb
Date: Wed, 18 Sep 2019 10:13:01 +0200 [thread overview]
Message-ID: <847b6bd0-5e52-52db-a0db-36a031d4f1f2@redhat.com> (raw)
In-Reply-To: <20190918052641.21300-1-richard.henderson@linaro.org>
On 18/09/19 07:26, Richard Henderson wrote:
> RFC because this doesn't work, and I don't quite understand why.
> The only failing test is {i386,x86_64} pxe-test -- the other
> migration tests that use notdirty all pass.
>
> Note that if you try to reproduce this on x86, you'll likely
> have to --disable-kvm, as otherwise the pxe-test will skip tcg.
>
> Anyone who knows how this works willing to have a look?
I think patch 2 is doing too much. Why don't you keep
memory_notdirty_write_prepare and memory_notdirty_write_complete at
first (so that the atomic path is completely unchanged wrt MMU lookup),
and then simplify that separately? Maybe that shows what's going on.
Paolo
next prev parent reply other threads:[~2019-09-18 8:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-18 5:26 [Qemu-devel] [RFC 0/3] Move notdirty handling to cputlb Richard Henderson
2019-09-18 5:26 ` [Qemu-devel] [RFC 1/3] exec: Adjust notdirty tracing Richard Henderson
2019-09-18 8:34 ` David Hildenbrand
2019-09-18 5:26 ` [Qemu-devel] [RFC 2/3] cputlb: Move NOTDIRTY handling from I/O path to TLB path Richard Henderson
2019-09-18 5:26 ` [Qemu-devel] [RFC 3/3] cputlb: Remove ATOMIC_MMU_DECLS Richard Henderson
2019-09-18 8:13 ` Paolo Bonzini [this message]
2019-09-18 8:30 ` [Qemu-devel] [RFC 0/3] Move notdirty handling to cputlb David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=847b6bd0-5e52-52db-a0db-36a031d4f1f2@redhat.com \
--to=pbonzini@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).