Re: [PATCH] build-sys: move Spice configure handling to meson

[Paolo Bonzini <pbonzini@redhat.com>]

On 07/10/21 12:24, marcandre.lureau@redhat.com wrote:
> +spice_protocol = dependency('spice-protocol', version: '>=0.12.3',
> +                            required: get_option('spice_protocol'))
> +spice = dependency('spice-server', version: '>=0.12.5',
> +                   required: get_option('spice'))

This needs to be:

spice_protocol = not_found
if not get_option('spice_protocol').auto() or have_system
   spice_protocol = ...
endif
spice = not_found
if not get_option('spice_protocol').auto() or have_system
   spice = ...
endif

in order to avoid useless warnings on --disable-user --static builds.

> +if spice.found()
> +  config_host += { 'CONFIG_SPICE': 'y' } # for audio/meson.build
> +endif

I have a pending series that removes the need for this, so I'll fold it 
in my queue.

(I didn't know about partial_dependency - nice one!)

Paolo