From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
Zhao Liu <zhao1.liu@intel.com>, Anton Johansson <anjo@rev.ng>,
Yanan Wang <wangyanan55@huawei.com>,
Eduardo Habkost <eduardo@habkost.net>
Subject: Re: [PATCH 2/2] hw/core/machine: Extract compat properties to machine-compat.c
Date: Tue, 1 Oct 2024 07:21:35 +0200 [thread overview]
Message-ID: <84a0a395-4b11-4db9-b7e3-c006d84394bb@redhat.com> (raw)
In-Reply-To: <20240930221900.59525-3-philmd@linaro.org>
On 01/10/2024 00.19, Philippe Mathieu-Daudé wrote:
> Extract machine compat properties to machine-compat.c.
> Add the unit to the meson specific_ss[] source set so
> we can use target specific (poisoned) definitions.
Why is this required? Shouldn't target-specific settings rather be done in
the various machine files instead?
Thomas
prev parent reply other threads:[~2024-10-01 14:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-30 22:18 [PATCH 0/2] hw/core/machine: Extract compat properties to machine-compat.c Philippe Mathieu-Daudé
2024-09-30 22:18 ` [PATCH 1/2] hw/core/machine: Add missing 'units.h' and 'error-report.h' headers Philippe Mathieu-Daudé
2024-10-08 3:55 ` Zhao Liu
2024-09-30 22:19 ` [PATCH 2/2] hw/core/machine: Extract compat properties to machine-compat.c Philippe Mathieu-Daudé
2024-10-01 5:21 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84a0a395-4b11-4db9-b7e3-c006d84394bb@redhat.com \
--to=thuth@redhat.com \
--cc=anjo@rev.ng \
--cc=eduardo@habkost.net \
--cc=marcel.apfelbaum@gmail.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=wangyanan55@huawei.com \
--cc=zhao1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).