qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: gert.wollny@collabora.com, qemu-devel@nongnu.org
Subject: Re: [PATCH] qemu/ui: set swap interval explicitly when OpenGL is enabled
Date: Wed, 11 Sep 2024 14:10:36 +0200	[thread overview]
Message-ID: <84a87c28-5175-4885-81bb-1ce17691833f@linaro.org> (raw)
In-Reply-To: <01020191e05ce6df-84da6386-62c2-4ce8-840e-ad216ac253dd-000000@eu-west-1.amazonses.com>

On 11/9/24 11:14, gert.wollny@collabora.com wrote:
> From: Gert Wollny <gert.wollny@collabora.com>
> 
> Before 176e3783f2ab (ui/sdl2: OpenGL window context)
> SDL_CreateRenderer was called unconditionally setting
> the swap interval to 0. Since SDL_CreateRenderer is now no
> longer called when OpenGL is enabled, the swap interval is
> no longer set explicitly and vsync handling depends on
> the environment settings which may lead to a performance
> regression with virgl as reported in
>     https://gitlab.com/qemu-project/qemu/-/issues/2565
> 
> Restore the old vsync handling by explicitly calling
> SDL_GL_SetSwapInterval if OpenGL is enabled.
> 
> Fixes: 176e3783f2ab (ui/sdl2: OpenGL window context)
> Closes: https://gitlab.com/qemu-project/qemu/-/issues/2565
> 
> Signed-off-by: Gert Wollny <gert.wollny@collabora.com>
> ---
>   ui/sdl2.c | 1 +
>   1 file changed, 1 insertion(+)

Queued, thanks.


  parent reply	other threads:[~2024-09-11 12:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-11  9:14 [PATCH] qemu/ui: set swap interval explicitly when OpenGL is enabled gert.wollny
2024-09-11 10:06 ` Marc-André Lureau
2024-09-11 12:10 ` Philippe Mathieu-Daudé [this message]
2024-09-16 14:46 ` Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=84a87c28-5175-4885-81bb-1ce17691833f@linaro.org \
    --to=philmd@linaro.org \
    --cc=gert.wollny@collabora.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).