qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH] tcg: Allow displaying TCG_TYPE_I128 arguments
Date: Wed, 22 Feb 2023 12:36:31 -1000	[thread overview]
Message-ID: <84b33d0f-ac04-ebbc-6ca1-d8c249044e5f@linaro.org> (raw)
In-Reply-To: <20230222212810.53857-1-philmd@linaro.org>

On 2/22/23 11:28, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   tcg/tcg.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/tcg/tcg.c b/tcg/tcg.c
> index a4a3da6804..3df2c6a6af 100644
> --- a/tcg/tcg.c
> +++ b/tcg/tcg.c
> @@ -1955,6 +1955,7 @@ static char *tcg_get_arg_str_ptr(TCGContext *s, char *buf, int buf_size,
>               break;
>   #if TCG_TARGET_REG_BITS > 32
>           case TCG_TYPE_I64:
> +        case TCG_TYPE_I128:
>               snprintf(buf, buf_size, "$0x%" PRIx64, ts->val);

This would be for a 128-bit constant, which we don't have.
Is this a guess, or hitting the assert, or what?


r~


  reply	other threads:[~2023-02-22 22:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-22 21:28 [PATCH] tcg: Allow displaying TCG_TYPE_I128 arguments Philippe Mathieu-Daudé
2023-02-22 22:36 ` Richard Henderson [this message]
2023-02-23 15:42   ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=84b33d0f-ac04-ebbc-6ca1-d8c249044e5f@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=alex.bennee@linaro.org \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).