From: Thomas Huth <thuth@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org
Subject: Re: [RFC PATCH] meson.build: fix cosmetics of compiler display
Date: Fri, 21 May 2021 15:58:00 +0200 [thread overview]
Message-ID: <84b82cde-6bdf-0870-6671-7714460155b3@redhat.com> (raw)
In-Reply-To: <20210521134411.31658-1-alex.bennee@linaro.org>
On 21/05/2021 15.44, Alex Bennée wrote:
> If you specify something like --cc="ccache gcc" on your configure line
> the summary output misses the rest of the cmd_array. Do some string
> joining to make it complete.
>
> Signed-off-by: Alex Bennée<alex.bennee@linaro.org>
> ---
> meson.build | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/meson.build b/meson.build
> index 1559e8d873..ca65552f31 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -2510,15 +2510,15 @@ summary(summary_info, bool_yn: true, section: 'Configurable features')
> summary_info = {}
> summary_info += {'host CPU': cpu}
> summary_info += {'host endianness': build_machine.endian()}
> -summary_info += {'C compiler': meson.get_compiler('c').cmd_array()[0]}
> -summary_info += {'Host C compiler': meson.get_compiler('c', native: true).cmd_array()[0]}
> +summary_info += {'C compiler': ' '.join(meson.get_compiler('c').cmd_array())}
> +summary_info += {'Host C compiler': ' '.join(meson.get_compiler('c', native: true).cmd_array())}
> if link_language == 'cpp'
> - summary_info += {'C++ compiler': meson.get_compiler('cpp').cmd_array()[0]}
> + summary_info += {'C++ compiler': ' '.join(meson.get_compiler('cpp').cmd_array())}
> else
> summary_info += {'C++ compiler': false}
> endif
> if targetos == 'darwin'
> - summary_info += {'Objective-C compiler': meson.get_compiler('objc').cmd_array()[0]}
> + summary_info += {'Objective-C compiler': ' '.join(meson.get_compiler('objc').cmd_array())}
> endif
> if targetos == 'windows'
> if 'WIN_SDK' in config_host
> -- 2.20.1
>
Tested-by: Thomas Huth <thuth@redhat.com>
prev parent reply other threads:[~2021-05-21 14:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-21 13:44 [RFC PATCH] meson.build: fix cosmetics of compiler display Alex Bennée
2021-05-21 13:58 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84b82cde-6bdf-0870-6671-7714460155b3@redhat.com \
--to=thuth@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).