From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Paolo Bonzini <pbonzini@redhat.com>,
mrezanin@redhat.com, qemu-devel@nongnu.org
Cc: imammedo@redhat.com, "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH] Add missing pixman dependecy
Date: Fri, 11 Nov 2022 12:34:05 +0100 [thread overview]
Message-ID: <84b99826-0d96-187a-7b95-0b9f79f4495f@linaro.org> (raw)
In-Reply-To: <d9c073ea-7379-7f51-f55b-b9c70d3daabf@redhat.com>
On 11/11/22 12:24, Paolo Bonzini wrote:
> On 11/9/22 16:34, mrezanin@redhat.com wrote:
>> From: Miroslav Rezanina <mrezanin@redhat.com>
>>
>> Commit cfead31326 'acpi: pc: vga: use AcpiDevAmlIf interface to build
>> VGA device descriptors' added
>> a new file - acpi-vga.c. This file (indirectly) includes pixman.h file
>> so we need to ensure pixman
>> is available when file is compiled.
>>
>> Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
>
> The patch is fine, but I think the new file does not need vga_int.h and
> therefore does not need to include pixman.h. Can you try?
MST already fixed, see:
https://lore.kernel.org/qemu-devel/20221109222112.74519-1-mst@redhat.com/
prev parent reply other threads:[~2022-11-11 11:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-09 15:34 [PATCH] Add missing pixman dependecy mrezanin
2022-11-09 16:14 ` Philippe Mathieu-Daudé
2022-11-11 6:42 ` Miroslav Rezanina
2022-11-11 11:24 ` Paolo Bonzini
2022-11-11 11:34 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84b99826-0d96-187a-7b95-0b9f79f4495f@linaro.org \
--to=philmd@linaro.org \
--cc=imammedo@redhat.com \
--cc=mrezanin@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).