qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Cc: "open list:RISC-V TCG CPUs" <qemu-riscv@nongnu.org>,
	Sagar Karandikar <sagark@eecs.berkeley.edu>,
	Bastian Koppelmann <kbastian@mail.uni-paderborn.de>,
	Palmer Dabbelt <palmer@sifive.com>,
	armbru@redhat.com, Alistair Francis <Alistair.Francis@wdc.com>
Subject: Re: [Qemu-devel] [PATCH v1 6/7] target/riscv: rationalise softfloat includes
Date: Thu, 8 Aug 2019 10:57:03 -0700	[thread overview]
Message-ID: <84c3374c-a309-6998-c61a-7c65b7c09d20@linaro.org> (raw)
In-Reply-To: <20190808164117.23348-7-alex.bennee@linaro.org>

On 8/8/19 9:41 AM, Alex Bennée wrote:
> We should avoid including the whole of softfloat headers in cpu.h and
> explicitly include it only where we will be calling softfloat
> functions. We can use the -types.h and -helpers.h in cpu.h for the few
> bits that are global.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>  target/riscv/cpu.c        | 1 +
>  target/riscv/cpu.h        | 2 +-
>  target/riscv/fpu_helper.c | 1 +
>  3 files changed, 3 insertions(+), 1 deletion(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~



  reply	other threads:[~2019-08-08 17:57 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-08 16:41 [Qemu-devel] [PATCH v1 0/7] softfloat header cleanups Alex Bennée
2019-08-08 16:41 ` [Qemu-devel] [PATCH v1 1/7] fpu: move LIT64 helper to softfloat-types Alex Bennée
2019-08-08 17:28   ` Richard Henderson
2019-08-09 10:08   ` Peter Maydell
2019-08-10 10:03     ` Alex Bennée
2019-08-08 16:41 ` [Qemu-devel] [PATCH v1 2/7] fpu: move inline helpers into a separate header Alex Bennée
2019-08-08 17:31   ` Richard Henderson
2019-08-08 16:41 ` [Qemu-devel] [PATCH v1 3/7] fpu: make softfloat-macros "self-contained" Alex Bennée
2019-08-08 17:49   ` Richard Henderson
2019-08-08 16:41 ` [Qemu-devel] [PATCH v1 4/7] fpu: rename softfloat-specialize.h -> .inc.c Alex Bennée
2019-08-08 17:50   ` Richard Henderson
2019-08-08 16:41 ` [Qemu-devel] [PATCH v1 5/7] target/mips: rationalise softfloat includes Alex Bennée
2019-08-08 17:55   ` Richard Henderson
2019-08-09  8:33     ` Alex Bennée
2019-08-08 16:41 ` [Qemu-devel] [PATCH v1 6/7] target/riscv: " Alex Bennée
2019-08-08 17:57   ` Richard Henderson [this message]
2019-08-10  1:55   ` Alistair Francis
2019-08-08 16:41 ` [Qemu-devel] [PATCH v1 7/7] targets (various): use softfloat-helpers.h where we can Alex Bennée
2019-08-08 17:58   ` Richard Henderson
2019-08-09  8:58   ` David Hildenbrand
2019-08-08 16:58 ` [Qemu-devel] [PATCH v1 0/7] softfloat header cleanups no-reply
2019-08-08 17:41 ` no-reply
2019-08-08 18:02 ` no-reply
2019-08-08 18:49 ` no-reply
2019-08-09  6:31 ` Markus Armbruster
2019-08-09  8:20   ` Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=84c3374c-a309-6998-c61a-7c65b7c09d20@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=Alistair.Francis@wdc.com \
    --cc=alex.bennee@linaro.org \
    --cc=armbru@redhat.com \
    --cc=kbastian@mail.uni-paderborn.de \
    --cc=palmer@sifive.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-riscv@nongnu.org \
    --cc=sagark@eecs.berkeley.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).