From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7240FC2D0A8 for ; Wed, 23 Sep 2020 10:17:28 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 020042145D for ; Wed, 23 Sep 2020 10:17:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="cBgvWjsv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 020042145D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:44370 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kL1q3-0004Bo-0I for qemu-devel@archiver.kernel.org; Wed, 23 Sep 2020 06:17:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43376) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kL1ox-0003Qf-3d for qemu-devel@nongnu.org; Wed, 23 Sep 2020 06:16:19 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:51287) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kL1ov-000395-Dw for qemu-devel@nongnu.org; Wed, 23 Sep 2020 06:16:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600856176; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=3gQ+C/+z4IBVVfK8alqq3wpCRbDW+yhaySGdtd38bXY=; b=cBgvWjsv3Z9LOfPvokZj0QcB2GZKg5XpRjLMu428ujrfXsuQFtszpa9ED3NFtP51wnLI6W GQbzUAqQ6Xt475Z76PvfTGM4W6pPQLfxf6Z2ERiZB74qMoxMcYnljH5DR7O3OLD2gcBnCO 1I6kyN3mOMuxkTaJ7vsizlHv+9LP9q4= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-34-t9AnHY9vNlKsghqciyKXGw-1; Wed, 23 Sep 2020 06:16:15 -0400 X-MC-Unique: t9AnHY9vNlKsghqciyKXGw-1 Received: by mail-wr1-f70.google.com with SMTP id a2so8616594wrp.8 for ; Wed, 23 Sep 2020 03:16:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:autocrypt:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=3gQ+C/+z4IBVVfK8alqq3wpCRbDW+yhaySGdtd38bXY=; b=ql7OGPs18UqQmmh69Nh5qObwa0RRhP76h8a1uyxpVeq/YF9T4aKYZoOHYun8dbDFYK dL9YAKoL41ovLP2b0IbOt6q3smOUSFyJFj4peMu0VavU6tNQ4IOT8IavLBd3MmFFbNUV eavNqE2gjMMmKjYZzA1u2VbfnX+8Km8iRlIhFC3XwdJxdCbLTINCW0v3ZFRLt0z4TvLj LFacj+0NiMzB8tklroIub6OAPF3DFSyQboHXQtj0PQMsyAhY3aJ9005jTudGnr06Uxx3 EGUvvOBEi6lH1nqjC3UBqblcgUGuTR4YJ4EfKv0+CTBBpD7/j/DwnFSIt6O2c3nBTSKy nxWQ== X-Gm-Message-State: AOAM533vtY9FYWh6bMcInEn+W6z9Ihj+jHnbx4mRjWJuzEXfD1hd+FcY LnJNeFN4nb7+uBVIYKPN7C/f6sY4KfK5RKr1gcRjukpqe9b/wkdfpHVilWVVze7M7ZqzztmCiU8 2LnoJ/aW6dZkFNxg= X-Received: by 2002:a05:600c:210c:: with SMTP id u12mr4878871wml.185.1600856173330; Wed, 23 Sep 2020 03:16:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzYWdli8HrIZGsioODLAUnYkR18eQ4FEDF0KLeIz2PmRsdFbB99W8XXdVaJzIbqVM33O54ugg== X-Received: by 2002:a05:600c:210c:: with SMTP id u12mr4878843wml.185.1600856173138; Wed, 23 Sep 2020 03:16:13 -0700 (PDT) Received: from [192.168.1.36] (65.red-83-57-170.dynamicip.rima-tde.net. [83.57.170.65]) by smtp.gmail.com with ESMTPSA id p1sm9717070wma.0.2020.09.23.03.16.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Sep 2020 03:16:12 -0700 (PDT) Subject: Re: [PATCH] modules: update qom object module comment To: Gerd Hoffmann , qemu-devel@nongnu.org References: <20200923091812.27297-1-kraxel@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Autocrypt: addr=philmd@redhat.com; keydata= mQINBDXML8YBEADXCtUkDBKQvNsQA7sDpw6YLE/1tKHwm24A1au9Hfy/OFmkpzo+MD+dYc+7 bvnqWAeGweq2SDq8zbzFZ1gJBd6+e5v1a/UrTxvwBk51yEkadrpRbi+r2bDpTJwXc/uEtYAB GvsTZMtiQVA4kRID1KCdgLa3zztPLCj5H1VZhqZsiGvXa/nMIlhvacRXdbgllPPJ72cLUkXf z1Zu4AkEKpccZaJspmLWGSzGu6UTZ7UfVeR2Hcc2KI9oZB1qthmZ1+PZyGZ/Dy+z+zklC0xl XIpQPmnfy9+/1hj1LzJ+pe3HzEodtlVA+rdttSvA6nmHKIt8Ul6b/h1DFTmUT1lN1WbAGxmg CH1O26cz5nTrzdjoqC/b8PpZiT0kO5MKKgiu5S4PRIxW2+RA4H9nq7nztNZ1Y39bDpzwE5Sp bDHzd5owmLxMLZAINtCtQuRbSOcMjZlg4zohA9TQP9krGIk+qTR+H4CV22sWldSkVtsoTaA2 qNeSJhfHQY0TyQvFbqRsSNIe2gTDzzEQ8itsmdHHE/yzhcCVvlUzXhAT6pIN0OT+cdsTTfif MIcDboys92auTuJ7U+4jWF1+WUaJ8gDL69ThAsu7mGDBbm80P3vvUZ4fQM14NkxOnuGRrJxO qjWNJ2ZUxgyHAh5TCxMLKWZoL5hpnvx3dF3Ti9HW2dsUUWICSQARAQABtDJQaGlsaXBwZSBN YXRoaWV1LURhdWTDqSAoUGhpbCkgPHBoaWxtZEByZWRoYXQuY29tPokCVQQTAQgAPwIbDwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4AWIQSJweePYB7obIZ0lcuio/1u3q3A3gUCXsfWwAUJ KtymWgAKCRCio/1u3q3A3ircD/9Vjh3aFNJ3uF3hddeoFg1H038wZr/xi8/rX27M1Vj2j9VH 0B8Olp4KUQw/hyO6kUxqkoojmzRpmzvlpZ0cUiZJo2bQIWnvScyHxFCv33kHe+YEIqoJlaQc JfKYlbCoubz+02E2A6bFD9+BvCY0LBbEj5POwyKGiDMjHKCGuzSuDRbCn0Mz4kCa7nFMF5Jv piC+JemRdiBd6102ThqgIsyGEBXuf1sy0QIVyXgaqr9O2b/0VoXpQId7yY7OJuYYxs7kQoXI 6WzSMpmuXGkmfxOgbc/L6YbzB0JOriX0iRClxu4dEUg8Bs2pNnr6huY2Ft+qb41RzCJvvMyu gS32LfN0bTZ6Qm2A8ayMtUQgnwZDSO23OKgQWZVglGliY3ezHZ6lVwC24Vjkmq/2yBSLakZE 6DZUjZzCW1nvtRK05ebyK6tofRsx8xB8pL/kcBb9nCuh70aLR+5cmE41X4O+MVJbwfP5s/RW 9BFSL3qgXuXso/3XuWTQjJJGgKhB6xXjMmb1J4q/h5IuVV4juv1Fem9sfmyrh+Wi5V1IzKI7 RPJ3KVb937eBgSENk53P0gUorwzUcO+ASEo3Z1cBKkJSPigDbeEjVfXQMzNt0oDRzpQqH2vp apo2jHnidWt8BsckuWZpxcZ9+/9obQ55DyVQHGiTN39hkETy3Emdnz1JVHTU0Q== Message-ID: <84d16233-5afb-410e-256a-025ac06c8682@redhat.com> Date: Wed, 23 Sep 2020 12:16:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200923091812.27297-1-kraxel@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/23 00:53:58 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.455, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 9/23/20 11:18 AM, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > util/module.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/util/module.c b/util/module.c > index 520986bd70ff..6df873593f95 100644 > --- a/util/module.c > +++ b/util/module.c > @@ -255,8 +255,10 @@ bool module_load_one(const char *prefix, const char *lib_name) > * only a very few devices & objects. > * > * So with the expectation that this will be rather the exception than > - * to rule and the list will not gain that many entries go with a > + * to rule and the list will not gain that many entries, go with a "than the rule"? > * simple manually maintained list for now. > + * > + * The list must be sorted by module (module_load_qom_all() needs this). > */ > static struct { > const char *type; >