From: Peter Chubb <peter.chubb@nicta.com.au>
To: Jean-Christophe DUBOIS <jcd@tribudubois.net>
Cc: peter.maydell@linaro.org, peter.chubb@nicta.com.au,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 2/2] i.MX: unify all function and variale name convention in GPT
Date: Thu, 30 May 2013 13:16:57 +1000 [thread overview]
Message-ID: <84ehcpw40m.wl%peter@chubb.wattle.id.au> (raw)
In-Reply-To: <1369763718-705-3-git-send-email-jcd@tribudubois.net>
>
> -static char const *imx_timerg_reg_name(uint32_t reg)
> +static char const *imx_timer_gpt_reg_name(uint32_t reg)
You could just use imc_gpt_xxx in line with the imx_epit_xxx naming
from your other patch series.
Otherwise this looks good.
--
Dr Peter Chubb peter.chubb AT nicta.com.au
http://www.ssrg.nicta.com.au Software Systems Research Group/NICTA
prev parent reply other threads:[~2013-05-30 3:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-28 17:55 [Qemu-devel] [PATCH v2 0/2] i.MX: improve GPT driver implementation Jean-Christophe DUBOIS
2013-05-28 17:55 ` [Qemu-devel] [PATCH v2 1/2] i.MX: implement a more complete version of the GPT timer Jean-Christophe DUBOIS
2013-05-28 17:55 ` [Qemu-devel] [PATCH v2 2/2] i.MX: unify all function and variale name convention in GPT Jean-Christophe DUBOIS
2013-05-30 3:16 ` Peter Chubb [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84ehcpw40m.wl%peter@chubb.wattle.id.au \
--to=peter.chubb@nicta.com.au \
--cc=jcd@tribudubois.net \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).