From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37874) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UhtMX-0003BI-UQ for qemu-devel@nongnu.org; Wed, 29 May 2013 23:17:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UhtMS-0001ns-Vy for qemu-devel@nongnu.org; Wed, 29 May 2013 23:17:13 -0400 Received: from lemon.ertos.nicta.com.au ([203.143.174.143]:43155) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UhtMS-0001mM-L7 for qemu-devel@nongnu.org; Wed, 29 May 2013 23:17:08 -0400 Date: Thu, 30 May 2013 13:16:57 +1000 Message-ID: <84ehcpw40m.wl%peter@chubb.wattle.id.au> From: Peter Chubb In-Reply-To: <1369763718-705-3-git-send-email-jcd@tribudubois.net> References: <1369763718-705-1-git-send-email-jcd@tribudubois.net> <1369763718-705-3-git-send-email-jcd@tribudubois.net> MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Subject: Re: [Qemu-devel] [PATCH v2 2/2] i.MX: unify all function and variale name convention in GPT List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jean-Christophe DUBOIS Cc: peter.maydell@linaro.org, peter.chubb@nicta.com.au, qemu-devel@nongnu.org > > -static char const *imx_timerg_reg_name(uint32_t reg) > +static char const *imx_timer_gpt_reg_name(uint32_t reg) You could just use imc_gpt_xxx in line with the imx_epit_xxx naming from your other patch series. Otherwise this looks good. -- Dr Peter Chubb peter.chubb AT nicta.com.au http://www.ssrg.nicta.com.au Software Systems Research Group/NICTA