From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D7766C87FCF for ; Mon, 4 Aug 2025 19:49:16 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uj1Aw-0006Yl-OG; Mon, 04 Aug 2025 15:48:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uj178-00026Q-Qn for qemu-devel@nongnu.org; Mon, 04 Aug 2025 15:44:54 -0400 Received: from mail-pl1-x62e.google.com ([2607:f8b0:4864:20::62e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uj177-0007Ur-3Y for qemu-devel@nongnu.org; Mon, 04 Aug 2025 15:44:54 -0400 Received: by mail-pl1-x62e.google.com with SMTP id d9443c01a7336-24022261323so62488185ad.1 for ; Mon, 04 Aug 2025 12:44:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1754336691; x=1754941491; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/M2pfZ3IVJzagLMECh6P3gXE47qrtA8ADSUmzBH4aYA=; b=Zt8zJeZQzywoTA4jj6Gv6O89aCMQ+WgBu3pVcsZUHt9Au/X75MAwMLbcOJTVCAk6g1 oCE9HYNKJs3wlcX37HaP9gq9VR00PJA0qWkAPJqL/Rtmd4P5RlILQ9T2GbHnBkJ9ipol qFZ4zwSOm8RiuK6WqhF1F01GCqNNfbsRecDinZbuLlrm55BhABetu7SyJeM5gjpzt2e5 QQMpKSeHE2gMtnyTzFIOHZUbzPpK/b+OFcfm4lxi3pmqbsHwU32nU3h+ox6UQ+RWa1Xd 3iXtG3onM0EvBrRgsJ5+KAzigzTQ/FWYaej7nBaGIXUPnuk0APYuLa3KUL7ZNsJHrzeu IpKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754336691; x=1754941491; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/M2pfZ3IVJzagLMECh6P3gXE47qrtA8ADSUmzBH4aYA=; b=W0ksicQp9pr12nWssoHpGBtQqrhI4IRZJK+Wv7HHASC+hrN+JtU3WazCgTOEEc+3+x E0BTAMFTP91X09Mki3n0QwDqoJVE2rhrrk7Mw3lbD+f4qVnF3kPRp8KncMj8YASXVGSz f/nr4M+tHWA9fANjlWqjfa364hog4h/teiQ2AfP46WZw2Z7JtTBhaccugnsU6ie1VaFq DZRz4g6Voh/vZaznQk/ye4R6SEDHOICLXrGQwlas3l32eX8SSvT2mBumMXN6iLTWygrO ewvyYHYME/UsNN98pnaWLOPuPQwVu4cOX4CpHlAlhvQaqT9VpnBl4UZh2HQ/6diCEezZ FYLw== X-Forwarded-Encrypted: i=1; AJvYcCWp1AMqdcohbQVOfXmxYvy7D1oCpx9gdVuz8ahpoBTdE1IkgB/qH9QBB8d/fPHInFF2e6KWg+TBbAc9@nongnu.org X-Gm-Message-State: AOJu0YyjkEF7LWVZTPM5Ic7e3BSCDZXvJqsknKPMZeyV5tvwy07vjcD6 P48bT2/LCXFndfb88F2uh3c6DNVR6Enss8tb0ajg55kooM/obiWP6sr0HNLa/ancHuY= X-Gm-Gg: ASbGnct8++Z4TUYMXUlzPmQiAVGdDmQozKW4EBLl6jSJLQo5lCOa/hwAIdH4yvKim6l k53kad3ezjFNwUkCKrk+B9y8moCJtp5Fp1bDaFOAL5WjWwdmYqxtz/FZ6sLTFB0BZXqobmQs/gu UN1QQrHSVH+C5NB0YMfi26Mem1vw7diETjdY6Wia48mEuXvTdNCrO6ErYSGn+0y463R0CEprSLy BpTaBlGq691XS3vKqLcj0PJH0HgeiAFyWdJnO0pxeMcv+eznBNV902RZQ4fu27DzxAAxvPbpM/l eHSHaZEyzICumWxLet55xnm88FwsjdiTXDb+hU24baBNTr+b40QM39pFMXz4iD0Eu2zbzBqpidi C2I2GbUr2QNxMmkd6HnVWotf0jf495NP9hmg= X-Google-Smtp-Source: AGHT+IEO3zmBrTux8983FgcXeTVpnOp1O5CXmf+NoTtWEDLEB4xA4BwmObJeu+UYuZrZ9rRvSRJz/w== X-Received: by 2002:a17:902:e5c6:b0:235:e1d6:2ac0 with SMTP id d9443c01a7336-24288e2205cmr8676275ad.24.1754336691372; Mon, 04 Aug 2025 12:44:51 -0700 (PDT) Received: from [192.168.1.87] ([38.41.223.211]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-241e8aafa77sm115629135ad.174.2025.08.04.12.44.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 Aug 2025 12:44:50 -0700 (PDT) Message-ID: <84f9c541-f9d2-4bc4-b2fc-980d71c1da49@linaro.org> Date: Mon, 4 Aug 2025 12:44:50 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 05/17] whpx: ifdef out winhvemulation on non-x86_64 Content-Language: en-US To: Mohamed Mediouni , qemu-devel@nongnu.org Cc: Shannon Zhao , Ani Sinha , =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , Phil Dennis-Jordan , Roman Bolshakov , Igor Mammedov , Eduardo Habkost , Mads Ynddal , =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= , Sunil Muthuswamy , Zhao Liu , "Michael S. Tsirkin" , Alexander Graf , qemu-arm@nongnu.org, Peter Maydell , Marcel Apfelbaum , Yanan Wang , Richard Henderson , Cameron Esfahani , Paolo Bonzini , =?UTF-8?Q?Marc-Andr=C3=A9_Lureau?= References: <20250804142326.72947-1-mohamed@unpredictable.fr> <20250804142326.72947-6-mohamed@unpredictable.fr> From: Pierrick Bouvier In-Reply-To: <20250804142326.72947-6-mohamed@unpredictable.fr> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::62e; envelope-from=pierrick.bouvier@linaro.org; helo=mail-pl1-x62e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 8/4/25 7:23 AM, Mohamed Mediouni wrote: > winhvemulation is x86_64 only. > > In the future, we might want to get rid of winhvemulation usage > entirely. > > Signed-off-by: Mohamed Mediouni > --- > accel/whpx/whpx-common.c | 16 ++++++++++++---- > include/system/whpx-common.h | 2 ++ > include/system/whpx-internal.h | 7 ++++++- > 3 files changed, 20 insertions(+), 5 deletions(-) > > diff --git a/accel/whpx/whpx-common.c b/accel/whpx/whpx-common.c > index b5e5fda696..e2d692126a 100644 > --- a/accel/whpx/whpx-common.c > +++ b/accel/whpx/whpx-common.c > @@ -141,9 +143,7 @@ int whpx_first_vcpu_starting(CPUState *cpu) > */ > int whpx_last_vcpu_stopping(CPUState *cpu) > { > -#ifdef __x86_64__ > whpx_apply_breakpoints(whpx_global.breakpoints.breakpoints, cpu, false); > -#endif > return 0; Rebase mistake? This was added with previous commit, but I don't think it was intended. Else, Reviewed-by: Pierrick Bouvier