From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43516) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1URg6C-0004q1-3a for qemu-devel@nongnu.org; Mon, 15 Apr 2013 05:53:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1URg6A-0000O5-7P for qemu-devel@nongnu.org; Mon, 15 Apr 2013 05:53:19 -0400 Received: from lemon.ertos.nicta.com.au ([203.143.174.143]:47505) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1URg69-0000Nx-T2 for qemu-devel@nongnu.org; Mon, 15 Apr 2013 05:53:18 -0400 Date: Mon, 15 Apr 2013 19:53:07 +1000 Message-ID: <84mwt086ik.wl%peter@chubb.wattle.id.au> From: Peter Chubb In-Reply-To: References: <84sj2s75yv.wl%peter@chubb.wattle.id.au> <84ppxw8d57.wl%peter@chubb.wattle.id.au> MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Subject: [Qemu-devel] [PATCH v2] target-arm: Reinsert SRS missing return statement. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Japheth.Lim@nicta.com.au, Peter Chubb , qemu-devel@nongnu.org Since patch 81465888c5306cd94abb9847e560796fd13d3c2f target-arm: factor out handling of SRS instruction the SRS instruction has not worked in QEMU. The problem is a missing return directive that was removed in the refactoring, so after decoding the instruction, qemu would do all the generic stuff that it should do for most instructions -- but not SRS. Signed-off-by: Peter Chubb --- target-arm/translate.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target-arm/translate.c b/target-arm/translate.c index 35a21be..a1b7b8c 100644 --- a/target-arm/translate.c +++ b/target-arm/translate.c @@ -6762,6 +6762,7 @@ static void disas_arm_insn(CPUARMState * env, DisasContext *s) } ARCH(6); gen_srs(s, (insn & 0x1f), (insn >> 23) & 3, insn & (1 << 21)); + return; } else if ((insn & 0x0e50ffe0) == 0x08100a00) { /* rfe */ int32_t offset; -- 1.7.10.4 -- Dr Peter Chubb peter.chubb AT nicta.com.au http://www.ssrg.nicta.com.au Software Systems Research Group/NICTA