From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51432) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1URdrf-0006aq-75 for qemu-devel@nongnu.org; Mon, 15 Apr 2013 03:30:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1URdra-0003cp-AD for qemu-devel@nongnu.org; Mon, 15 Apr 2013 03:30:11 -0400 Received: from lemon.ertos.nicta.com.au ([203.143.174.143]:46663) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1URdrZ-0003Zz-Vb for qemu-devel@nongnu.org; Mon, 15 Apr 2013 03:30:06 -0400 Date: Mon, 15 Apr 2013 17:29:56 +1000 Message-ID: <84ppxw8d57.wl%peter@chubb.wattle.id.au> From: Peter Chubb In-Reply-To: References: <84sj2s75yv.wl%peter@chubb.wattle.id.au> MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Subject: Re: [Qemu-devel] [PATCH] target-arm: Reinsert SRS missing return statements. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Japheth.Lim@nicta.com.au, Peter Chubb , qemu-devel@nongnu.org >>>>> "Peter" == Peter Maydell writes: Peter> On 15 April 2013 05:50, Peter Chubb Peter> wrote: >> >> >> Since patch 81465888c5306cd94abb9847e560796fd13d3c2f target-arm: >> factor out handling of SRS instruction the SRS instruction has not >> worked in QEMU. >> >> The problem is a return directive that was removed in the >> refactoring, so after decoding the instruction, qemu would fall >> through to do stuff that it should not have done. Peter> Nice catch for the ARM decoder, but not needed for thumb2 I Peter> think? It was there in the code that was removed. I didn't analyse too deeply, as nothing we do uses the thumb version. Peter C -- Dr Peter Chubb peter.chubb AT nicta.com.au http://www.ssrg.nicta.com.au Software Systems Research Group/NICTA