From: <Peter.Chubb@data61.csiro.au>
To: alistair.francis@xilinx.com
Cc: qemu-devel@nongnu.org, alistair23@gmail.com,
philippe@mathieu-daude.net, berrange@redhat.com,
armbru@redhat.com, jcody@redhat.com, kwolf@redhat.com,
mreitz@redhat.com, ronniesahlberg@gmail.com, pbonzini@redhat.com,
pl@kamp.de, jdurgin@redhat.com, rjones@redhat.com,
crosthwaite.peter@gmail.com, rth@twiddle.net,
aneesh.kumar@linux.vnet.ibm.com, groug@kaod.org, robh@kernel.org,
peter.maydell@linaro.org, peter.chubb@nicta.com.au,
ehabkost@redhat.com, marcel@redhat.com, mst@redhat.com,
imammedo@redhat.com, david@gibson.dropbear.id.au, agraf@suse.de,
kraxel@redhat.com, jasowang@redhat.com, mtosatti@redhat.com,
borntraeger@de.ibm.com, cohuck@redhat.com, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH v1 3/6] Convert error_report() to warn_report()
Date: Fri, 7 Jul 2017 00:14:02 +0000 [thread overview]
Message-ID: <84wp7layt8.wl-Peter.Chubb@data61.csiro.au> (raw)
In-Reply-To: <0a1d5638543965d532284bdc6fce391cf9f509d0.1499381754.git.alistair.francis@xilinx.com>
>>>>> "Alistair" == Alistair Francis <alistair.francis@xilinx.com> writes:
Alistair> Convert all uses of error_report("[Ww]arning:"... to use
Alistair> warn_report() instead. This helps standardise on a single
Alistair> method of printing warnings to the user.
In a number of cases the initial double quote has been removed as
well. This will have to be fixed.
e.g.,
- error_report("Warning: 'filename' option specified. "
+ warn_report('filename' option specified. "
I'm surprised the result compiled cleanly.
Peter C
--
Dr Peter Chubb Tel: +61 2 9490 5852 http://ts.data61.csiro.au/
Trustworthy Systems Group Data61 (formerly NICTA)
next prev parent reply other threads:[~2017-07-07 0:46 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-06 23:49 [Qemu-devel] [PATCH v1 0/6] Implement a warning_report function Alistair Francis
2017-07-06 23:49 ` [Qemu-devel] [PATCH v1 1/6] util/qemu-error: Rename error_print_loc() to be more generic Alistair Francis
2017-07-06 23:49 ` [Qemu-devel] [PATCH v1 2/6] error: Functions to report warnings and informational messages Alistair Francis
2017-07-07 12:59 ` Markus Armbruster
2017-07-07 17:10 ` Alistair Francis
2017-07-06 23:49 ` [Qemu-devel] [PATCH v1 3/6] Convert error_report() to warn_report() Alistair Francis
2017-07-07 0:14 ` Peter.Chubb [this message]
2017-07-07 17:19 ` Alistair Francis
2017-07-10 8:06 ` Markus Armbruster
2017-07-10 12:02 ` Philippe Mathieu-Daudé
2017-07-07 1:09 ` David Gibson
2017-07-07 6:33 ` Thomas Huth
2017-07-07 11:58 ` Eduardo Habkost
2017-07-07 12:07 ` Thomas Huth
2017-07-07 6:33 ` Greg Kurz
2017-07-07 8:29 ` Cornelia Huck
2017-07-07 12:06 ` Eduardo Habkost
2017-07-07 17:39 ` Alistair Francis
2017-07-07 12:32 ` Stefan Hajnoczi
2017-07-07 12:48 ` Markus Armbruster
2017-07-07 17:30 ` Alistair Francis
2017-07-10 7:49 ` Marcel Apfelbaum
2017-07-06 23:49 ` [Qemu-devel] [PATCH v1 4/6] char-socket: Report TCP socket waiting as information Alistair Francis
2017-07-07 11:32 ` Philippe Mathieu-Daudé
2017-07-06 23:49 ` [Qemu-devel] [PATCH v1 5/6] error: Implement the warn and free Error functions Alistair Francis
2017-07-06 23:49 ` [Qemu-devel] [PATCH v1 6/6] Convert error_report*_err() to warn_report*_err() Alistair Francis
2017-07-07 11:41 ` Philippe Mathieu-Daudé
2017-07-07 12:07 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84wp7layt8.wl-Peter.Chubb@data61.csiro.au \
--to=peter.chubb@data61.csiro.au \
--cc=agraf@suse.de \
--cc=alistair.francis@xilinx.com \
--cc=alistair23@gmail.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=crosthwaite.peter@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=ehabkost@redhat.com \
--cc=groug@kaod.org \
--cc=imammedo@redhat.com \
--cc=jasowang@redhat.com \
--cc=jcody@redhat.com \
--cc=jdurgin@redhat.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=marcel@redhat.com \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.chubb@nicta.com.au \
--cc=peter.maydell@linaro.org \
--cc=philippe@mathieu-daude.net \
--cc=pl@kamp.de \
--cc=qemu-devel@nongnu.org \
--cc=rjones@redhat.com \
--cc=robh@kernel.org \
--cc=ronniesahlberg@gmail.com \
--cc=rth@twiddle.net \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).