From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55498) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCk1Z-0000gN-FP for qemu-devel@nongnu.org; Fri, 23 Aug 2013 01:35:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VCk1T-0007gr-Fx for qemu-devel@nongnu.org; Fri, 23 Aug 2013 01:35:05 -0400 Received: from mx4-phx2.redhat.com ([209.132.183.25]:58080) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCk1T-0007gi-7o for qemu-devel@nongnu.org; Fri, 23 Aug 2013 01:34:59 -0400 Date: Fri, 23 Aug 2013 01:34:54 -0400 (EDT) From: Paolo Bonzini Message-ID: <85279077.3140282.1377236094231.JavaMail.root@redhat.com> In-Reply-To: <5216D569.9000802@linux.vnet.ibm.com> References: <1377069536-12658-1-git-send-email-lilei@linux.vnet.ibm.com> <1377069536-12658-7-git-send-email-lilei@linux.vnet.ibm.com> <52149937.4040700@redhat.com> <5216D569.9000802@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 06/18] bugfix: wrong error set by ram_control_load_hook() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Lei Li Cc: aarcange@redhat.com, aliguori@us.ibm.com, quintela@redhat.com, qemu-devel@nongnu.org, mrhines@linux.vnet.ibm.com, lagarcia@br.ibm.com, rcj@linux.vnet.ibm.com > On 08/21/2013 06:40 PM, Paolo Bonzini wrote: > > Il 21/08/2013 09:18, Lei Li ha scritto: > >> It should set negative error value if there has been an error. > >> > >> Signed-off-by: Lei Li > >> --- > >> savevm.c | 2 +- > >> 1 files changed, 1 insertions(+), 1 deletions(-) > >> > >> diff --git a/savevm.c b/savevm.c > >> index 1522d95..f10e031 100644 > >> --- a/savevm.c > >> +++ b/savevm.c > >> @@ -649,7 +649,7 @@ void ram_control_after_iterate(QEMUFile *f, uint64_t > >> flags) > >> > >> void ram_control_load_hook(QEMUFile *f, uint64_t flags) > >> { > >> - int ret = 0; > >> + int ret = -1; > > -EINVAL > > OK, thanks. Can you extract the patches that I reviewed positively, plus this one, and send them separately? Thanks! Paolo