From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 832ECC43461 for ; Tue, 8 Sep 2020 19:01:55 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DA89F20757 for ; Tue, 8 Sep 2020 19:01:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="g/rIPNA+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DA89F20757 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:42654 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kFisL-0006YJ-Qu for qemu-devel@archiver.kernel.org; Tue, 08 Sep 2020 15:01:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57326) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kFiqj-00053i-RB for qemu-devel@nongnu.org; Tue, 08 Sep 2020 15:00:13 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:32560 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kFiqh-00046a-Gl for qemu-devel@nongnu.org; Tue, 08 Sep 2020 15:00:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1599591609; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fQJH4CzuU16NfYH+kuXkODsbyvBrAdjDpPxl1zYXV5g=; b=g/rIPNA+oebo+HLBZOJvHYMxMe9gdgOS7qkTDQHFxVYFt9sCb+WDKIB/QVoIHd0eOergsY TAXxk2Cc1vmINFHMD2cBfOrmb8QL1c+HnoCa9Gwzb217jpQylmU8SybOtlrY3YJvJlUYX3 4E+X4+MsXPSYGFsgDdwRAHiFU3PX8wU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-73-bWkktPc-N06-ehlKhZSm0A-1; Tue, 08 Sep 2020 15:00:02 -0400 X-MC-Unique: bWkktPc-N06-ehlKhZSm0A-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 35F0E801AF7; Tue, 8 Sep 2020 19:00:00 +0000 (UTC) Received: from [10.3.112.176] (ovpn-112-176.phx2.redhat.com [10.3.112.176]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 32A9F838C1; Tue, 8 Sep 2020 18:59:54 +0000 (UTC) Subject: Re: [PULL 02/16] ci: fixes msys2 build by upgrading capstone to 4.0.2 To: Yonggang Luo , qemu-devel@nongnu.org References: <20200908184918.1085-1-luoyonggang@gmail.com> <20200908184918.1085-3-luoyonggang@gmail.com> From: Eric Blake Organization: Red Hat, Inc. Message-ID: <852c95bc-9576-cbb7-471f-f8ef037f8fda@redhat.com> Date: Tue, 8 Sep 2020 13:59:53 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200908184918.1085-3-luoyonggang@gmail.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eblake@redhat.com X-Mimecast-Spam-Score: 0.002 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Received-SPF: pass client-ip=207.211.31.120; envelope-from=eblake@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/08 12:55:20 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -36 X-Spam_score: -3.7 X-Spam_bar: --- X-Spam_report: (-3.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-1.626, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Ed Maste , qemu-block@nongnu.org, Stefan Weil , Xie Changlong , Peter Lieven , Michael Roth , Markus Armbruster , Gerd Hoffmann , Wen Congyang , Max Reitz , Li-Wen Hsu Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 9/8/20 1:49 PM, Yonggang Luo wrote: > Signed-off-by: Yonggang Luo > --- > capstone | 2 +- > configure | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) The commit message is sparse; it might be nice to give more details about what error is fixed, or possibly even mention of the fact of which capstone commit id that is in 4.0.2 but not the current version matters to qemu on msys. > > diff --git a/capstone b/capstone > index 22ead3e0bf..1d23053284 160000 > --- a/capstone > +++ b/capstone > @@ -1 +1 @@ > -Subproject commit 22ead3e0bfdb87516656453336160e0a37b066bf > +Subproject commit 1d230532840a37ac032c6ab80128238fc930c6c1 > diff --git a/configure b/configure > index 4231d56bcc..f4f8bc3756 100755 > --- a/configure > +++ b/configure > @@ -5156,7 +5156,7 @@ case "$capstone" in > LIBCAPSTONE=libcapstone.a > fi > capstone_libs="-Lcapstone -lcapstone" > - capstone_cflags="-I${source_path}/capstone/include" > + capstone_cflags="-I${source_path}/capstone/include -I${source_path}/capstone/include/capstone" This change was not mentioned in the commit message. Did capstone 4.0.2 change where its include files live? Or is it a separate bug, and you are fixing two things at once (in which case, doing two separate commits might be nicer)? -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org