qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Havard Skinnemoen <hskinnemoen@google.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH] tests: Inject test name also when the test fails
Date: Mon, 29 Jun 2020 17:17:03 +0200	[thread overview]
Message-ID: <8532e28d-2d7b-0671-8f62-b64eb5d29781@redhat.com> (raw)
In-Reply-To: <20200628213046.2028271-1-hskinnemoen@google.com>

On 28/06/20 23:30, Havard Skinnemoen wrote:
> If a test is unsuccessful, the result is "not ok", which does not match
> the regex because it includes a space.
> 
> This regex matches both "ok" and "not ok".
> 
> Signed-off-by: Havard Skinnemoen <hskinnemoen@google.com>
> ---
>  tests/Makefile.include | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/Makefile.include b/tests/Makefile.include
> index 3f4448a20b..09df2d3f86 100644
> --- a/tests/Makefile.include
> +++ b/tests/Makefile.include
> @@ -637,7 +637,7 @@ define do_test_tap
>            { export MALLOC_PERTURB_=$${MALLOC_PERTURB_:-$$(( $${RANDOM:-0} % 255 + 1))} $2; \
>              $(foreach COMMAND, $1, \
>  	      $(COMMAND) -m=$(SPEED) -k --tap < /dev/null \
> -	      | sed "s/^[a-z][a-z]* [0-9]* /&$(notdir $(COMMAND)) /" || true; ) } \
> +	      | sed "s/^\(not \)\?ok [0-9]* /&$(notdir $(COMMAND)) /" || true; ) } \
>  	      | ./scripts/tap-merge.pl | tee "$@" \
>  	      | ./scripts/tap-driver.pl $(if $(V),, --show-failures-only), \
>  	  "TAP","$@")
> 

Queued, thanks.

Paolo



      reply	other threads:[~2020-06-29 15:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-28 21:30 [PATCH] tests: Inject test name also when the test fails Havard Skinnemoen
2020-06-29 15:17 ` Paolo Bonzini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8532e28d-2d7b-0671-8f62-b64eb5d29781@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=hskinnemoen@google.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).