qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Ninad Palsule <ninad@linux.ibm.com>
To: "Cédric Le Goater" <clg@kaod.org>,
	"Thomas Huth" <thuth@redhat.com>,
	qemu-devel@nongnu.org, peter.maydell@linaro.org, andrew@aj.id.au,
	joel@jms.id.au, pbonzini@redhat.com, marcandre.lureau@redhat.com,
	berrange@redhat.com, philmd@linaro.org, lvivier@redhat.com
Cc: qemu-arm@nongnu.org
Subject: Re: [PATCH v3 8/8] hw/fsi: Documentation and testing
Date: Fri, 8 Sep 2023 17:31:37 -0500	[thread overview]
Message-ID: <8539cf6a-fbe7-4d94-9ad2-1011f7d70fe8@linux.ibm.com> (raw)
In-Reply-To: <c722f63e-697b-eeab-82f0-7155b2a4632b@kaod.org>

Hello Cedric,

On 8/30/23 02:13, Cédric Le Goater wrote:
> On 8/30/23 09:05, Thomas Huth wrote:
>> On 30/08/2023 04.26, Ninad Palsule wrote:
>>> Added FSI document
>>> Added basic qtests for FSI model.
>>> Added MAINITAINER for FSI
>>> Replaced some qemu logs to traces.
>>
>> Sorry, that's not how we rework patch series in the QEMU development 
>> process. Please squash the log traces changes into the patches that 
>> introduced the original code, and please put the MAINTAINERS update, 
>> documentation and qtests into separate patches.
>
> yes. This is true for some Kconfig changes also. On that topic, please
> make sure FSI is compiled only when ASPEED_SOC is selected. It could be
> useful for the PPC PowerNV machines one day but the models are not
> available yet.

Fixed the Kconfig rework and make sure that FSI is selected only with 
ASPEED_SOC.


Thanks for the review.

~Ninad

>
> I will try to go through the series this week. Wait a bit for the v4.
>
> Thanks,
>
> C.
>
>


  reply	other threads:[~2023-09-08 23:12 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-30  2:26 [PATCH v3 0/8] Introduce model for IBM's FSI Ninad Palsule
2023-08-30  2:26 ` [PATCH v3 1/8] hw/fsi: Introduce IBM's Local bus Ninad Palsule
2023-08-30  2:26 ` [PATCH v3 2/8] hw/fsi: Introduce IBM's scratchpad Ninad Palsule
2023-08-30  2:26 ` [PATCH v3 3/8] hw/fsi: Introduce IBM's cfam,fsi-slave Ninad Palsule
2023-08-30  2:26 ` [PATCH v3 4/8] hw/fsi: Introduce IBM's FSI Ninad Palsule
2023-08-30  2:26 ` [PATCH v3 5/8] hw/fsi: IBM's On-chip Peripheral Bus Ninad Palsule
2023-08-30  2:26 ` [PATCH v3 6/8] hw/fsi: Aspeed APB2OPB interface Ninad Palsule
2023-08-30  2:26 ` [PATCH v3 7/8] hw/arm: Hook up FSI module in AST2600 Ninad Palsule
2023-08-30  2:26 ` [PATCH v3 8/8] hw/fsi: Documentation and testing Ninad Palsule
2023-08-30  7:05   ` Thomas Huth
2023-08-30  7:13     ` Cédric Le Goater
2023-09-08 22:31       ` Ninad Palsule [this message]
2023-09-08 22:30     ` Ninad Palsule

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8539cf6a-fbe7-4d94-9ad2-1011f7d70fe8@linux.ibm.com \
    --to=ninad@linux.ibm.com \
    --cc=andrew@aj.id.au \
    --cc=berrange@redhat.com \
    --cc=clg@kaod.org \
    --cc=joel@jms.id.au \
    --cc=lvivier@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).