From: David Hildenbrand <david@redhat.com>
To: Thomas Huth <thuth@redhat.com>, qemu-s390x@nongnu.org
Cc: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Subject: Re: [PATCH] target/s390x/cpu.h: Remove unused SIGP_MODE defines
Date: Fri, 15 Oct 2021 14:59:10 +0200 [thread overview]
Message-ID: <853fc01f-ab5a-232a-8cb7-2908e30b0411@redhat.com> (raw)
In-Reply-To: <20211015124219.1330830-1-thuth@redhat.com>
On 15.10.21 14:42, Thomas Huth wrote:
> These are unused since commit 075e52b816648f21 ("s390x/cpumodel:
> we are always in zarchitecture mode") and it's unlikely that we
> will ever need them again. So let's simply remove them now.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> target/s390x/cpu.h | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/target/s390x/cpu.h b/target/s390x/cpu.h
> index 3153d053e9..ca3845d023 100644
> --- a/target/s390x/cpu.h
> +++ b/target/s390x/cpu.h
> @@ -674,11 +674,6 @@ QEMU_BUILD_BUG_ON(sizeof(SysIB) != 4096);
> #define SIGP_STAT_INVALID_ORDER 0x00000002UL
> #define SIGP_STAT_RECEIVER_CHECK 0x00000001UL
>
> -/* SIGP SET ARCHITECTURE modes */
> -#define SIGP_MODE_ESA_S390 0
> -#define SIGP_MODE_Z_ARCH_TRANS_ALL_PSW 1
> -#define SIGP_MODE_Z_ARCH_TRANS_CUR_PSW 2
> -
> /* SIGP order code mask corresponding to bit positions 56-63 */
> #define SIGP_ORDER_MASK 0x000000ff
>
>
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2021-10-15 13:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-15 12:42 [PATCH] target/s390x/cpu.h: Remove unused SIGP_MODE defines Thomas Huth
2021-10-15 12:59 ` David Hildenbrand [this message]
2021-10-15 14:21 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=853fc01f-ab5a-232a-8cb7-2908e30b0411@redhat.com \
--to=david@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).