From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Thomas Huth <thuth@redhat.com>, John Snow <jsnow@redhat.com>,
qemu-devel@nongnu.org
Cc: BALATON Zoltan <balaton@eik.bme.hu>, qemu-block@nongnu.org
Subject: Re: [PATCH v2 4/7] hw/ide: Move IDE device related definitions to ide-dev.h
Date: Wed, 21 Feb 2024 21:52:10 +0100 [thread overview]
Message-ID: <858c4ece-bfea-4211-aca9-4b541ad35fb8@linaro.org> (raw)
In-Reply-To: <767097cd-06f5-4eec-a778-94b60f947e2b@redhat.com>
On 21/2/24 20:13, Thomas Huth wrote:
> On 21/02/2024 19.43, Philippe Mathieu-Daudé wrote:
>> On 20/2/24 09:55, Thomas Huth wrote:
>>> Unentangle internal.h by moving public IDE device related
>>
>> Disentangle ... from? Untangle? TIL Unentangle.
>
> You're right, "disentangle" seems to be the more appropriate word.
> I'll fix it up.
No need, series queued and fixed!
>> Anyway I'm not a native English speaker, so:
>> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>
> Thanks!
>
> Thomas
>
>
next prev parent reply other threads:[~2024-02-21 20:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-20 8:54 [PATCH v2 0/7] hw/ide: Clean up hw/ide/qdev.c and include/hw/ide/internal.h Thomas Huth
2024-02-20 8:54 ` [PATCH v2 1/7] hw/ide: Add the possibility to disable the CompactFlash device in the build Thomas Huth
2024-02-20 8:55 ` [PATCH v2 2/7] hw/ide: Split qdev.c into ide-bus.c and ide-dev.c Thomas Huth
2024-02-20 8:55 ` [PATCH v2 3/7] hw/ide: Move IDE DMA related definitions to a separate header ide-dma.h Thomas Huth
2024-02-21 18:37 ` Philippe Mathieu-Daudé
2024-02-20 8:55 ` [PATCH v2 4/7] hw/ide: Move IDE device related definitions to ide-dev.h Thomas Huth
2024-02-21 18:43 ` Philippe Mathieu-Daudé
2024-02-21 19:13 ` Thomas Huth
2024-02-21 20:52 ` Philippe Mathieu-Daudé [this message]
2024-02-20 8:55 ` [PATCH v2 5/7] hw/ide: Move IDE bus related definitions to a new header ide-bus.h Thomas Huth
2024-02-21 18:46 ` Philippe Mathieu-Daudé
2024-02-20 8:55 ` [PATCH v2 6/7] hw/ide: Remove the include/hw/ide.h legacy file Thomas Huth
2024-02-20 8:55 ` [PATCH v2 7/7] hw/ide: Stop exposing internal.h to non-IDE files Thomas Huth
2024-02-21 11:54 ` [PATCH v2 0/7] hw/ide: Clean up hw/ide/qdev.c and include/hw/ide/internal.h Mark Cave-Ayland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=858c4ece-bfea-4211-aca9-4b541ad35fb8@linaro.org \
--to=philmd@linaro.org \
--cc=balaton@eik.bme.hu \
--cc=jsnow@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).