Re: [Qemu-devel] [PATCH] egl-helpers.h: add a missing X11 include

["Philippe Mathieu-Daudé" <philmd@redhat.com>]

On 1/16/19 6:53 AM, Gerd Hoffmann wrote:
> On Tue, Jan 15, 2019 at 09:47:08PM +0100, Alexander Kanavin wrote:
>> On Tue, 15 Jan 2019 at 20:58, Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
>>> Cc'ing Gerd (the maintainer) and Marc-André.
>>>
>>>> |  EGLSurface qemu_egl_init_surface_x11(EGLContext ectx, Window win);
>>>> |                                                        ^~~~~~
>>>> |                                                        minor
> 
>>> <epoxy/egl.h> includes <EGL/eglplatform.h> which contains:
>>>
>>>   #if defined(MESA_EGL_NO_X11_HEADERS)
>>>   typedef void            *EGLNativeDisplayType;
>>>   typedef khronos_uintptr_t EGLNativePixmapType;
>>>   typedef khronos_uintptr_t EGLNativeWindowType;
>>>   #else
>>>   /* X11 (tentative)  */
>>>   #include <X11/Xlib.h>
>>>
>>> So Window should already be declared.
>>
>> Hello Philippe,
>>
>> we build mesa explicitly using "--with-platforms='drm surfaceless'"
>> (x11 is not in the list), which means MESA_EGL_NO_X11_HEADERS is
>> indeed defined according to [1]. We also enable opengl and gtk in
>> qemu.
> 
> Hmm, should we use EGLNativeWindowType instead of Window then?

Yes, I prefer this too but was not sure you'd like that :)

Alexander do you want to write the patch or should I?