From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57512) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T7Pwe-0004TF-JL for qemu-devel@nongnu.org; Fri, 31 Aug 2012 08:03:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T7Pwc-00006K-JL for qemu-devel@nongnu.org; Fri, 31 Aug 2012 08:03:28 -0400 Received: from mailpro.odiso.net ([89.248.209.98]:59319) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T7Pwc-000067-AL for qemu-devel@nongnu.org; Fri, 31 Aug 2012 08:03:26 -0400 Date: Fri, 31 Aug 2012 14:02:59 +0200 (CEST) From: Alexandre DERUMIER Message-ID: <85aa24b3-7780-46c7-aa49-d69abcd8ae57@mailpro> In-Reply-To: <201208301800.q7UI04R9009678@int-mx12.intmail.prod.int.phx2.redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] ahci: add migration support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jason Baron Cc: kwolf@redhat.com, aliguori@us.ibm.com, jan kiszka , qemu-devel@nongnu.org, agraf@suse.de, yamahata@valinux.co.jp, alex williamson , afaerber@suse.de works fine here with debian squeeze + debian wheezy guests. ----- Mail original ----- De: "Jason Baron" =C3=80: kwolf@redhat.com, afaerber@suse.de, agraf@suse.de Cc: qemu-devel@nongnu.org, yamahata@valinux.co.jp, "alex williamson" , aliguori@us.ibm.com, "jan kiszka" Envoy=C3=A9: Jeudi 30 Ao=C3=BBt 2012 20:00:04 Objet: [Qemu-devel] [PATCH] ahci: add migration support Add support for ahci migration. This patch builds upon the patches posted previously by Andreas Faerber: http://lists.gnu.org/archive/html/qemu-devel/2012-08/msg01538.html (I hope I am giving Andreas proper credit for his work.) I've tested these patches by migrating Windows 7 and Fedora 16 guests on both piix with ahci attached and on q35 (which has a built-in ahci controll= er). Signed-off-by: Jason Baron --- hw/ide/ahci.c | 64 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++= - hw/ide/ahci.h | 10 +++++++++ hw/ide/ich.c | 11 +++++++-- 3 files changed, 81 insertions(+), 4 deletions(-) diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index b53c757..e94509b 100644 --- a/hw/ide/ahci.c +++ b/hw/ide/ahci.c @@ -1204,6 +1204,65 @@ void ahci_reset(AHCIState *s) } } +static const VMStateDescription vmstate_ahci_device =3D { + .name =3D "ahci port", + .version_id =3D 1, + .fields =3D (VMStateField []) { + VMSTATE_IDE_BUS(port, AHCIDevice), + VMSTATE_UINT32(port_state, AHCIDevice), + VMSTATE_UINT32(finished, AHCIDevice), + VMSTATE_UINT32(port_regs.lst_addr, AHCIDevice), + VMSTATE_UINT32(port_regs.lst_addr_hi, AHCIDevice), + VMSTATE_UINT32(port_regs.fis_addr, AHCIDevice), + VMSTATE_UINT32(port_regs.fis_addr_hi, AHCIDevice), + VMSTATE_UINT32(port_regs.irq_stat, AHCIDevice), + VMSTATE_UINT32(port_regs.irq_mask, AHCIDevice), + VMSTATE_UINT32(port_regs.cmd, AHCIDevice), + VMSTATE_UINT32(port_regs.tfdata, AHCIDevice), + VMSTATE_UINT32(port_regs.sig, AHCIDevice), + VMSTATE_UINT32(port_regs.scr_stat, AHCIDevice), + VMSTATE_UINT32(port_regs.scr_ctl, AHCIDevice), + VMSTATE_UINT32(port_regs.scr_err, AHCIDevice), + VMSTATE_UINT32(port_regs.scr_act, AHCIDevice), + VMSTATE_UINT32(port_regs.cmd_issue, AHCIDevice), + VMSTATE_END_OF_LIST() + }, +}; + +static int ahci_state_post_load(void *opaque, int version_id) +{ + int i; + AHCIState *s =3D opaque; + + for (i =3D 0; i < s->ports; i++) { + AHCIPortRegs *pr =3D &s->dev[i].port_regs; + + map_page(&s->dev[i].lst, + ((uint64_t)pr->lst_addr_hi << 32) | pr->lst_addr, 1024); + map_page(&s->dev[i].res_fis, + ((uint64_t)pr->fis_addr_hi << 32) | pr->fis_addr, 256); + } + + return 0; +} + +const VMStateDescription vmstate_ahci =3D { + .name =3D "ahci", + .version_id =3D 1, + .post_load =3D ahci_state_post_load, + .fields =3D (VMStateField []) { + VMSTATE_STRUCT_VARRAY_POINTER_INT32(dev, AHCIState, ports, + vmstate_ahci_device, AHCIDevice), + VMSTATE_UINT32(control_regs.cap, AHCIState), + VMSTATE_UINT32(control_regs.ghc, AHCIState), + VMSTATE_UINT32(control_regs.irqstatus, AHCIState), + VMSTATE_UINT32(control_regs.impl, AHCIState), + VMSTATE_UINT32(control_regs.version, AHCIState), + VMSTATE_UINT32(idp_index, AHCIState), + VMSTATE_END_OF_LIST() + }, +}; + typedef struct SysbusAHCIState { SysBusDevice busdev; AHCIState ahci; @@ -1212,7 +1271,10 @@ typedef struct SysbusAHCIState { static const VMStateDescription vmstate_sysbus_ahci =3D { .name =3D "sysbus-ahci", - .unmigratable =3D 1, + .fields =3D (VMStateField []) { + VMSTATE_AHCI(ahci, AHCIPCIState), + VMSTATE_END_OF_LIST() + }, }; static void sysbus_ahci_reset(DeviceState *dev) diff --git a/hw/ide/ahci.h b/hw/ide/ahci.h index 1200a56..7719dbf 100644 --- a/hw/ide/ahci.h +++ b/hw/ide/ahci.h @@ -307,6 +307,16 @@ typedef struct AHCIPCIState { AHCIState ahci; } AHCIPCIState; +extern const VMStateDescription vmstate_ahci; + +#define VMSTATE_AHCI(_field, _state) { \ + .name =3D (stringify(_field)), \ + .size =3D sizeof(AHCIState), \ + .vmsd =3D &vmstate_ahci, \ + .flags =3D VMS_STRUCT, \ + .offset =3D vmstate_offset_value(_state, _field, AHCIState), \ +} + typedef struct NCQFrame { uint8_t fis_type; uint8_t c; diff --git a/hw/ide/ich.c b/hw/ide/ich.c index 272b773..ae6f56f 100644 --- a/hw/ide/ich.c +++ b/hw/ide/ich.c @@ -79,9 +79,14 @@ #define ICH9_IDP_INDEX 0x10 #define ICH9_IDP_INDEX_LOG2 0x04 -static const VMStateDescription vmstate_ahci =3D { +static const VMStateDescription vmstate_ich9_ahci =3D { .name =3D "ahci", - .unmigratable =3D 1, + .version_id =3D 1, + .fields =3D (VMStateField []) { + VMSTATE_PCI_DEVICE(card, AHCIPCIState), + VMSTATE_AHCI(ahci, AHCIPCIState), + VMSTATE_END_OF_LIST() + }, }; static void pci_ich9_reset(DeviceState *dev) @@ -152,7 +157,7 @@ static void ich_ahci_class_init(ObjectClass *klass, voi= d *data) k->device_id =3D PCI_DEVICE_ID_INTEL_82801IR; k->revision =3D 0x02; k->class_id =3D PCI_CLASS_STORAGE_SATA; - dc->vmsd =3D &vmstate_ahci; + dc->vmsd =3D &vmstate_ich9_ahci; dc->reset =3D pci_ich9_reset; } -- 1.7.1 -- -- Alexandre D e rumier Ing=C3=A9nieur Syst=C3=A8mes et R=C3=A9seaux Fixe : 03 20 68 88 85 Fax : 03 20 68 90 88 45 Bvd du G=C3=A9n=C3=A9ral Leclerc 59100 Roubaix 12 rue Marivaux 75002 Paris