From: Eric Blake <eblake@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: qemu-devel@nongnu.org, Juan Quintela <quintela@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] migration: fix crash in when incoming client channel setup fails
Date: Tue, 19 Jun 2018 11:31:17 -0500 [thread overview]
Message-ID: <85ae384d-9684-261f-9224-5343d670d69c@redhat.com> (raw)
In-Reply-To: <20180619155859.GE26829@redhat.com>
On 06/19/2018 10:58 AM, Daniel P. Berrangé wrote:
>> So, what happens with this fix, does the destination exit cleanly, or
>> stay to accept another connection or what?
>
> It stays around and can accept another connection, which is actually
> quite desirable, as it limits impact of a malicious client from DOS'ing
> the genuine client by racing to connect first.
Compare to NBD which had a CVE created for the DOS aspect of a malicious
client connecting first; see commit 0c9390d9, CVE-2017-9524.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
prev parent reply other threads:[~2018-06-19 16:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-19 15:17 [Qemu-devel] [PATCH] migration: fix crash in when incoming client channel setup fails Daniel P. Berrangé
2018-06-19 15:45 ` Dr. David Alan Gilbert
2018-06-19 15:58 ` Daniel P. Berrangé
2018-06-19 16:00 ` Dr. David Alan Gilbert
2018-06-19 16:02 ` Daniel P. Berrangé
2018-06-19 16:28 ` Daniel P. Berrangé
2018-06-19 16:31 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85ae384d-9684-261f-9224-5343d670d69c@redhat.com \
--to=eblake@redhat.com \
--cc=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).