qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Cédric Le Goater" <clg@redhat.com>
To: John Levon <john.levon@nutanix.com>,
	Mark Cave-Ayland <mark.caveayland@nutanix.com>
Cc: qemu-devel@nongnu.org,
	Thanos Makatos <thanos.makatos@nutanix.com>,
	Alex Williamson <alex.williamson@redhat.com>
Subject: Re: [PATCH v2 3/4] hw/vfio-user: wait for proxy close correctly
Date: Tue, 15 Jul 2025 11:37:43 +0200	[thread overview]
Message-ID: <85bd0b0a-3c9a-448d-8d91-e4e162e066b9@redhat.com> (raw)
In-Reply-To: <aHYgd9pF2V5tYylq@lent>

On 7/15/25 11:33, John Levon wrote:
> On Tue, Jul 15, 2025 at 10:01:59AM +0100, Mark Cave-Ayland wrote:
> 
>> On 15/07/2025 06:52, John Levon wrote:
>>
>>> Coverity reported:
>>>
>>> CID 1611806: Concurrent data access violations (BAD_CHECK_OF_WAIT_COND)
>>>
>>> A wait is performed without a loop. If there is a spurious wakeup, the
>>> condition may not be satisfied.
>>>
>>> Fix this by checking ->state for VFIO_PROXY_CLOSED in a loop.
>>>
>>> Resolves: Coverity CID 1611806
>>> Fixes: 0b3d881a ("vfio-user: implement message receive infrastructure")
>>> Signed-off-by: John Levon <john.levon@nutanix.com>
>>
>> Is this definitely the right patch? The v2 posted at
>> https://patchew.org/QEMU/20250711124500.1611628-1-john.levon@nutanix.com/
>> contains the updated commit message mentioning the rename of the callback,
>> whereas this one doesn't?
> 
> Yep, sorry, picked the wrong commit message (but same commit contents).
> 
> Should I resend?
yep. Please pick up the trailers.

Thanks,

C.



  reply	other threads:[~2025-07-15  9:39 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-15  5:52 [PATCH v2 0/4] vfio-user fixes John Levon
2025-07-15  5:52 ` [PATCH v2 1/4] hw/vfio-user: add Cédric Le Goater as a maintainer John Levon
2025-07-15  8:57   ` Mark Cave-Ayland
2025-07-15  5:52 ` [PATCH v2 2/4] hw/vfio: fix region fd initialization John Levon
2025-07-15  5:52 ` [PATCH v2 3/4] hw/vfio-user: wait for proxy close correctly John Levon
2025-07-15  9:01   ` Mark Cave-Ayland
2025-07-15  9:33     ` John Levon
2025-07-15  9:37       ` Cédric Le Goater [this message]
2025-07-15  5:52 ` [PATCH v2 4/4] hw/vfio-user: fix use of uninitialized variable John Levon
2025-07-15  5:56 ` [PATCH v2 0/4] vfio-user fixes Cédric Le Goater
2025-07-15  5:58   ` Cédric Le Goater

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=85bd0b0a-3c9a-448d-8d91-e4e162e066b9@redhat.com \
    --to=clg@redhat.com \
    --cc=alex.williamson@redhat.com \
    --cc=john.levon@nutanix.com \
    --cc=mark.caveayland@nutanix.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thanos.makatos@nutanix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).