From: Richard Henderson <richard.henderson@linaro.org>
To: Thomas Huth <thuth@redhat.com>,
David Hildenbrand <david@redhat.com>,
qemu-devel@nongnu.org
Cc: qemu-s390x@nongnu.org, Ilya Leoshkevich <iii@linux.ibm.com>
Subject: Re: [PATCH] target/s390x/tcg/mem_helper: Remove bad assert() statement
Date: Fri, 17 Mar 2023 07:33:07 -0700 [thread overview]
Message-ID: <85cfe4cf-d546-a6fe-adb4-f3d64e6eaf84@linaro.org> (raw)
In-Reply-To: <20230317135737.597570-1-thuth@redhat.com>
On 3/17/23 06:57, Thomas Huth wrote:
> The "assert(!nonfault)" statement can be triggered by running the
> "mvpg" s390x kvm-unit-test with TCG. According to Richard: "... the
> assert looks backward. We should only arrive there if nonfault was
> true for the probe (otherwise the probe would have raised the
> exception directly). I would think we could just remove the assert."
>
> Fixes: 4049431478 ("target/s390x: Fix s390_probe_access for user-only")
> Suggested-by: Richard Henderson<richard.henderson@linaro.org>
> Signed-off-by: Thomas Huth<thuth@redhat.com>
> ---
> target/s390x/tcg/mem_helper.c | 1 -
> 1 file changed, 1 deletion(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2023-03-17 14:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-17 13:57 [PATCH] target/s390x/tcg/mem_helper: Remove bad assert() statement Thomas Huth
2023-03-17 14:33 ` Richard Henderson [this message]
2023-03-20 11:20 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85cfe4cf-d546-a6fe-adb4-f3d64e6eaf84@linaro.org \
--to=richard.henderson@linaro.org \
--cc=david@redhat.com \
--cc=iii@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).