From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E6CCFC52D7C for ; Thu, 22 Aug 2024 00:58:30 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sgw8k-0000kq-Fy; Wed, 21 Aug 2024 20:57:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sgw8i-0000iV-IX for qemu-devel@nongnu.org; Wed, 21 Aug 2024 20:57:24 -0400 Received: from mail-pj1-x1032.google.com ([2607:f8b0:4864:20::1032]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sgw8g-0006Un-Oi for qemu-devel@nongnu.org; Wed, 21 Aug 2024 20:57:24 -0400 Received: by mail-pj1-x1032.google.com with SMTP id 98e67ed59e1d1-2d439583573so174533a91.3 for ; Wed, 21 Aug 2024 17:57:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1724288240; x=1724893040; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=1263F4mV4Km5S8FWF7EIKOjU44U7JCrIs1gfANxD3mU=; b=KN3BDT8grI/Vqlnmk5/gnyjINs9fp+zc7Jd176AUT5343ZK3CdBYtbyX6pjh2f6iOW q0GYP/NGrzocv6AsvicIOdVnNLV+BOygZudBTnyeR6XyrdpFe5yHRcLHh/HbIjZOgniz X856hWh615DwbCBgnn09SeRj8RqgZIqZO7WQlP57Cq1M9j2SC7f7ue56PugMj7qjsaGO Z5HAxoi2aMdgGZ8bJ2+gUqrgOHakRT7WtEbz3qkzOOSNxDIFdEDLD49rOlchpRIX/p2F XFARmMl1aIDFvRq2jDGgtFC2UwUMN08kYw8TSQI9rXqdqYQ1ZYETTfXKNgP/JhkVigTF l+uA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724288240; x=1724893040; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1263F4mV4Km5S8FWF7EIKOjU44U7JCrIs1gfANxD3mU=; b=kNbPjL6rgodB4kYsyNoJA8Oozqelt69erPLNalLLAco8Oya0wXj4EuxNVrJ8QltTlg IgNBjG+zRz7pr8QaqZICWhoP4mqwSg4VXCim2cSC4n/Zwu1pJF32zP38vmfF7lwsRr9f 1Caj4+h2L7jEYkAh2DIBmqAM6YILSfldIfxn0ZpduoVEBC3HXOObAZnrRgoCSMHXvkr7 WrnLJ1pFls7dMz3JkP0xqEUGBPjj7qAqr65NKN7ZuyCgtmPNXpOlPmDdHgZNecOUUUR/ DZaUOOw8t/UY7FhmqwIbB1kqKwTtsSSKwx30wnC1OY5mvcl0y060pXxNC3kiarZaCD2/ 0obQ== X-Forwarded-Encrypted: i=1; AJvYcCWJlP5rQpNbw55jeqn8DSgKv+LRX+l1ooSSqOaVTbjKtTdd1doWg/h9Yf6RlIOLkpdIfuB8FdDv2vni@nongnu.org X-Gm-Message-State: AOJu0Yw1Y1qr1zgyUxXFd/14N6y0pH9m+ntIfxUqAMMg/x7ng7i0ehMu eLJv587bgLFI61JOVsTr6xup7gFpoJ7Q7nTIHxwAzV8dDypOV7GF6fnl8jA8tmM= X-Google-Smtp-Source: AGHT+IG6PBMktc7XjaT2glIiA03QR0ojwwl77ZJkXaiuGk4NvMXH0wX7yf9Lda6WElPWl1nXCLGWbQ== X-Received: by 2002:a17:90b:4a04:b0:2d3:ce99:44b6 with SMTP id 98e67ed59e1d1-2d5e9ec96d8mr4277160a91.29.1724288240078; Wed, 21 Aug 2024 17:57:20 -0700 (PDT) Received: from [192.168.98.227] (60-242-98-186.static.tpgi.com.au. [60.242.98.186]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2d5ebbb009bsm2583228a91.41.2024.08.21.17.57.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Aug 2024 17:57:19 -0700 (PDT) Message-ID: <85deb108-cac1-492e-89be-0997510fde0b@linaro.org> Date: Thu, 22 Aug 2024 10:57:10 +1000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 13/16] target/riscv: implement zicfiss instructions To: Deepak Gupta , qemu-riscv@nongnu.org, qemu-devel@nongnu.org Cc: palmer@dabbelt.com, Alistair.Francis@wdc.com, bmeng.cn@gmail.com, liwei1518@gmail.com, dbarboza@ventanamicro.com, zhiwei_liu@linux.alibaba.com, jim.shu@sifive.com, andy.chiu@sifive.com, kito.cheng@sifive.com References: <20240821215014.3859190-1-debug@rivosinc.com> <20240821215014.3859190-14-debug@rivosinc.com> Content-Language: en-US From: Richard Henderson In-Reply-To: <20240821215014.3859190-14-debug@rivosinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::1032; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1032.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 8/22/24 07:50, Deepak Gupta wrote: > --- a/target/riscv/insn_trans/trans_rva.c.inc > +++ b/target/riscv/insn_trans/trans_rva.c.inc > @@ -18,6 +18,8 @@ > * this program. If not, see . > */ > > +#include "exec/memop.h" > + Why? This will have been done long ago, within the includes of translate.c, the parent of this file. > +static bool trans_ssrdp(DisasContext *ctx, arg_ssrdp *a) > +{ > + if (!ctx->bcfi_enabled || a->rd == 0) { > + return false; > + } > + > + TCGv dest = tcg_temp_new(); dest = dest_gpr(ctx, a->rd); r~