From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Titus Rwantare <titusr@google.com>, minyard@acm.org
Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org,
Patrick Venture <venture@google.com>
Subject: Re: [PATCH 4/5] hw/i2c: pmbus: block uninitialised string reads
Date: Wed, 29 Mar 2023 16:15:40 +0200 [thread overview]
Message-ID: <85eca121-d447-7861-c73b-b68adb517d53@linaro.org> (raw)
In-Reply-To: <20230322175513.1550412-5-titusr@google.com>
On 22/3/23 18:55, Titus Rwantare wrote:
> Devices models calling pmbus_send_string can't be relied upon to
> send a non-zero pointer. This logs an error and doesn't segfault.
>
> Reviewed-by: Patrick Venture <venture@google.com>
> Signed-off-by: Titus Rwantare <titusr@google.com>
> ---
> hw/i2c/pmbus_device.c | 7 +++++++
> 1 file changed, 7 insertions(+)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2023-03-29 14:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 17:55 [PATCH 0/5] PMBus fixes and new functions Titus Rwantare
2023-03-22 17:55 ` [PATCH 1/5] hw/i2c: pmbus add support for block receive Titus Rwantare
2023-03-30 16:18 ` Corey Minyard
2023-03-31 0:05 ` Titus Rwantare
2023-03-22 17:55 ` [PATCH 2/5] hw/i2c: pmbus: add vout mode bitfields Titus Rwantare
2023-03-30 16:20 ` Corey Minyard
2023-03-30 16:25 ` Corey Minyard
2023-03-22 17:55 ` [PATCH 3/5] hw/i2c: pmbus: add fan support Titus Rwantare
2023-03-30 16:22 ` Corey Minyard
2023-03-22 17:55 ` [PATCH 4/5] hw/i2c: pmbus: block uninitialised string reads Titus Rwantare
2023-03-29 14:15 ` Philippe Mathieu-Daudé [this message]
2023-03-30 16:23 ` Corey Minyard
2023-03-22 17:55 ` [PATCH 5/5] hw/i2c: pmbus: add VCAP register Titus Rwantare
2023-03-30 16:25 ` Corey Minyard
2023-03-30 14:24 ` [PATCH 0/5] PMBus fixes and new functions Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85eca121-d447-7861-c73b-b68adb517d53@linaro.org \
--to=philmd@linaro.org \
--cc=minyard@acm.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=titusr@google.com \
--cc=venture@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).