* [Qemu-devel] [PATCH] qemu-img: Fix error "Unknown option 'size'" when using host_device format
@ 2010-03-02 18:52 Bitti
2010-03-03 9:58 ` Kevin Wolf
0 siblings, 1 reply; 2+ messages in thread
From: Bitti @ 2010-03-02 18:52 UTC (permalink / raw)
To: qemu-devel; +Cc: dustin.kirkland
[-- Attachment #1: Type: text/plain, Size: 899 bytes --]
qemu-kvm-0.11.0
When I run:
sudo qemu-img convert ubuntu-kvm/disk0.qcow2 -O host_device /dev/vg01/vm_test
I get this:
Unknown option 'size'
Ubuntu Bug:
https://bugs.launchpad.net/ubuntu/+source/qemu-kvm/+bug/460542
Signed-off-by: Bitti <bitaround@gmail.com>
---
--- block/raw-posix.c.orig 2009-09-23 10:30:02.000000000 +0300
+++ block/raw-posix.c 2009-10-25 18:22:08.780047000 +0200
@@ -1172,6 +1172,15 @@
return ret;
}
+static QEMUOptionParameter host_device_create_options[] = {
+ {
+ .name = BLOCK_OPT_SIZE,
+ .type = OPT_SIZE,
+ .help = "Virtual disk size"
+ },
+ { NULL }
+};
+
static BlockDriver bdrv_host_device = {
.format_name = "host_device",
.instance_size = sizeof(BDRVRawState),
@@ -1197,6 +1206,7 @@
.bdrv_aio_ioctl = hdev_aio_ioctl,
#endif
#endif
+ .create_options = host_device_create_options,
};
#ifdef __linux__
[-- Attachment #2: raw-posix.c.diff --]
[-- Type: text/x-patch, Size: 635 bytes --]
--- block/raw-posix.c.orig 2009-09-23 10:30:02.000000000 +0300
+++ block/raw-posix.c 2009-10-25 18:22:08.780047000 +0200
@@ -1172,6 +1172,15 @@
return ret;
}
+static QEMUOptionParameter host_device_create_options[] = {
+ {
+ .name = BLOCK_OPT_SIZE,
+ .type = OPT_SIZE,
+ .help = "Virtual disk size"
+ },
+ { NULL }
+};
+
static BlockDriver bdrv_host_device = {
.format_name = "host_device",
.instance_size = sizeof(BDRVRawState),
@@ -1197,6 +1206,7 @@
.bdrv_aio_ioctl = hdev_aio_ioctl,
#endif
#endif
+ .create_options = host_device_create_options,
};
#ifdef __linux__
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] qemu-img: Fix error "Unknown option 'size'" when using host_device format
2010-03-02 18:52 [Qemu-devel] [PATCH] qemu-img: Fix error "Unknown option 'size'" when using host_device format Bitti
@ 2010-03-03 9:58 ` Kevin Wolf
0 siblings, 0 replies; 2+ messages in thread
From: Kevin Wolf @ 2010-03-03 9:58 UTC (permalink / raw)
To: Bitti; +Cc: qemu-devel, dustin.kirkland
Am 02.03.2010 19:52, schrieb Bitti:
> qemu-kvm-0.11.0
>
> When I run:
> sudo qemu-img convert ubuntu-kvm/disk0.qcow2 -O host_device /dev/vg01/vm_test
>
> I get this:
> Unknown option 'size'
>
> Ubuntu Bug:
> https://bugs.launchpad.net/ubuntu/+source/qemu-kvm/+bug/460542
>
> Signed-off-by: Bitti <bitaround@gmail.com>
This has been fixed in master by commit 0b4ce02e which is contained in
0.12, too.
Kevin
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-03-03 9:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-02 18:52 [Qemu-devel] [PATCH] qemu-img: Fix error "Unknown option 'size'" when using host_device format Bitti
2010-03-03 9:58 ` Kevin Wolf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).