From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NmXCo-0000nX-BS for qemu-devel@nongnu.org; Tue, 02 Mar 2010 13:52:30 -0500 Received: from [199.232.76.173] (port=50443 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NmXCn-0000n5-Ri for qemu-devel@nongnu.org; Tue, 02 Mar 2010 13:52:29 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NmXCm-00047H-HF for qemu-devel@nongnu.org; Tue, 02 Mar 2010 13:52:29 -0500 Received: from fg-out-1718.google.com ([72.14.220.158]:38378) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NmXCm-000477-6p for qemu-devel@nongnu.org; Tue, 02 Mar 2010 13:52:28 -0500 Received: by fg-out-1718.google.com with SMTP id 19so275651fgg.10 for ; Tue, 02 Mar 2010 10:52:22 -0800 (PST) MIME-Version: 1.0 Date: Tue, 2 Mar 2010 20:52:22 +0200 Message-ID: <85f01a8b1003021052l5211388at956f6dd49e739162@mail.gmail.com> Subject: [Qemu-devel] [PATCH] qemu-img: Fix error "Unknown option 'size'" when using host_device format From: Bitti Content-Type: multipart/mixed; boundary=001636418649ac09c30480d5dd14 List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: dustin.kirkland@gmail.com --001636418649ac09c30480d5dd14 Content-Type: text/plain; charset=ISO-8859-1 qemu-kvm-0.11.0 When I run: sudo qemu-img convert ubuntu-kvm/disk0.qcow2 -O host_device /dev/vg01/vm_test I get this: Unknown option 'size' Ubuntu Bug: https://bugs.launchpad.net/ubuntu/+source/qemu-kvm/+bug/460542 Signed-off-by: Bitti --- --- block/raw-posix.c.orig 2009-09-23 10:30:02.000000000 +0300 +++ block/raw-posix.c 2009-10-25 18:22:08.780047000 +0200 @@ -1172,6 +1172,15 @@ return ret; } +static QEMUOptionParameter host_device_create_options[] = { + { + .name = BLOCK_OPT_SIZE, + .type = OPT_SIZE, + .help = "Virtual disk size" + }, + { NULL } +}; + static BlockDriver bdrv_host_device = { .format_name = "host_device", .instance_size = sizeof(BDRVRawState), @@ -1197,6 +1206,7 @@ .bdrv_aio_ioctl = hdev_aio_ioctl, #endif #endif + .create_options = host_device_create_options, }; #ifdef __linux__ --001636418649ac09c30480d5dd14 Content-Type: text/x-patch; charset=US-ASCII; name="raw-posix.c.diff" Content-Disposition: attachment; filename="raw-posix.c.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_g6b1hjod0 LS0tIGJsb2NrL3Jhdy1wb3NpeC5jLm9yaWcJMjAwOS0wOS0yMyAxMDozMDowMi4wMDAwMDAwMDAg KzAzMDAKKysrIGJsb2NrL3Jhdy1wb3NpeC5jCTIwMDktMTAtMjUgMTg6MjI6MDguNzgwMDQ3MDAw ICswMjAwCkBAIC0xMTcyLDYgKzExNzIsMTUgQEAKICAgICByZXR1cm4gcmV0OwogfQogCitzdGF0 aWMgUUVNVU9wdGlvblBhcmFtZXRlciBob3N0X2RldmljZV9jcmVhdGVfb3B0aW9uc1tdID0gewor ICAgIHsKKyAgICAgICAgLm5hbWUgPSBCTE9DS19PUFRfU0laRSwKKyAgICAgICAgLnR5cGUgPSBP UFRfU0laRSwKKyAgICAgICAgLmhlbHAgPSAiVmlydHVhbCBkaXNrIHNpemUiCisgICAgfSwKKyAg ICB7IE5VTEwgfQorfTsKKwogc3RhdGljIEJsb2NrRHJpdmVyIGJkcnZfaG9zdF9kZXZpY2UgPSB7 CiAgICAgLmZvcm1hdF9uYW1lCT0gImhvc3RfZGV2aWNlIiwKICAgICAuaW5zdGFuY2Vfc2l6ZQk9 IHNpemVvZihCRFJWUmF3U3RhdGUpLApAQCAtMTE5Nyw2ICsxMjA2LDcgQEAKICAgICAuYmRydl9h aW9faW9jdGwgICAgID0gaGRldl9haW9faW9jdGwsCiAjZW5kaWYKICNlbmRpZgorICAgIC5jcmVh dGVfb3B0aW9ucyA9IGhvc3RfZGV2aWNlX2NyZWF0ZV9vcHRpb25zLAogfTsKIAogI2lmZGVmIF9f bGludXhfXwo= --001636418649ac09c30480d5dd14--