From: Pierrick Bouvier <pierrick.bouvier@linaro.org>
To: Roque Arcudia Hernandez <roqueh@google.com>,
thuth@redhat.com, richard.henderson@linaro.org,
jansene@google.com, mjt@tls.msk.ru
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH] hw/usb: Use __attribute__((packed)) vs __packed
Date: Fri, 1 Nov 2024 14:32:32 -0700 [thread overview]
Message-ID: <85f34a23-bbe0-4996-9735-3d6d1a708727@linaro.org> (raw)
In-Reply-To: <20241101211720.3354111-1-roqueh@google.com>
On 11/1/24 14:17, Roque Arcudia Hernandez wrote:
> __packed is non standard and is not present in clang-cl.
> __attribute__((packed)) has the same semantics.
>
> Signed-off-by: Erwin Jansen <jansene@google.com>
> Signed-off-by: Roque Arcudia Hernandez <roqueh@google.com>
> ---
> include/hw/usb/dwc2-regs.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/hw/usb/dwc2-regs.h b/include/hw/usb/dwc2-regs.h
> index 523b112c5e..b8b4266543 100644
> --- a/include/hw/usb/dwc2-regs.h
> +++ b/include/hw/usb/dwc2-regs.h
> @@ -838,7 +838,7 @@
> struct dwc2_dma_desc {
> uint32_t status;
> uint32_t buf;
> -} __packed;
> +} QEMU_PACKED;
>
> /* Host Mode DMA descriptor status quadlet */
>
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
next prev parent reply other threads:[~2024-11-01 21:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-01 21:17 [PATCH] hw/usb: Use __attribute__((packed)) vs __packed Roque Arcudia Hernandez
2024-11-01 21:32 ` Pierrick Bouvier [this message]
2024-11-04 7:37 ` Thomas Huth
2024-11-21 10:01 ` Michael Tokarev
2024-11-21 10:24 ` Thomas Huth
2024-11-21 11:23 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85f34a23-bbe0-4996-9735-3d6d1a708727@linaro.org \
--to=pierrick.bouvier@linaro.org \
--cc=jansene@google.com \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=roqueh@google.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).