Re: [Qemu-devel] [PATCH v2 0/4] pvh: add new PVH option rom

[Liam Merwick <liam.merwick@oracle.com>]

On 15/01/2019 10:00, Stefano Garzarella wrote:
> This patch series is based on "[RFC v2 0/4] QEMU changes to do PVH boot" and
> provides a PVH option rom that can be used with SeaBIOS to boot uncompressed
> kernel using the x86/HVM direct boot ABI.
> 
> Patches 1 and 2 are to prepare the PVH option rom, moving common functions in a
> new header.  Patch 3 adds the new PVH option rom and patch 4 uses it when we
> are booting an uncompressed kernel using the x86/HVM direct boot ABI.
> 
> Changes in v2:
> - addressed comments by Stefan and Eric:
>    - Patch 2: moved inludes on top of linuxboot_dma.c and add <stdint.h> in
>      optrom.h
>    - Patch 4: added check of pvh.bin in xen_load_linux()
> - modified commit message of patch 2 to explain better the patch
> 
> Stefano Garzarella (4):
>    linuxboot_dma: remove duplicate definitions of FW_CFG
>    linuxboot_dma: move common functions in a new header
>    optionrom: add new PVH option rom
>    hw/i386/pc: use PVH option rom
> 
>   hw/i386/pc.c                      |   5 +
>   pc-bios/optionrom/Makefile        |   5 +-
>   pc-bios/optionrom/linuxboot_dma.c | 112 +++--------------
>   pc-bios/optionrom/optrom.h        | 110 ++++++++++++++++
>   pc-bios/optionrom/optrom_fw_cfg.h |  92 ++++++++++++++
>   pc-bios/optionrom/pvh.S           | 200 ++++++++++++++++++++++++++++++
>   pc-bios/optionrom/pvh_main.c      | 117 +++++++++++++++++
>   7 files changed, 544 insertions(+), 97 deletions(-)
>   create mode 100644 pc-bios/optionrom/optrom.h
>   create mode 100644 pc-bios/optionrom/optrom_fw_cfg.h
>   create mode 100644 pc-bios/optionrom/pvh.S
>   create mode 100644 pc-bios/optionrom/pvh_main.c
> 

I had a few very minor comments on patch3, but with that, for the series:

Reviewed-by: Liam Merwick <liam.merwick@oracle.com>