From: Paolo Bonzini <pbonzini@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@gmail.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Daniel P. Berrangé" <berrange@redhat.com>,
qemu-stable <qemu-stable@nongnu.org>,
"QEMU Developers" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] mux: fix ctrl-a b again
Date: Wed, 18 Apr 2018 12:55:16 +0200 [thread overview]
Message-ID: <860de622-d4cc-d1bf-ae27-e4d70d5d22f0@redhat.com> (raw)
In-Reply-To: <CAJ+F1CJ4HurD8=OC+qhHSEuNDkO7_QQaiJtH_RVHSu4-xzrqag@mail.gmail.com>
On 18/04/2018 12:36, Marc-André Lureau wrote:
>
> + if (chr == NULL || chr->be) {
> + name = g_strdup_printf("discarding-serial%d", i);
> + chr = qemu_chr_new(name, "null");
> + } else {
> + name = g_strdup_printf("serial%d", i);
> + }
>
> Why do you check if chr->be ? In case of a mux chardev, it may already
> have an active frontend (yeah be is CharBackend which is the frontend,
> I still can't grasp that either, please Paolo change your mind! ;).
CharBackend is not the frontend, it is *used* by the front-end. It is
the qemu_chr_* functions that are named wrong (they're named according
to the user rather than the recipient).
Paolo
next prev parent reply other threads:[~2018-04-18 10:55 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-16 18:18 [Qemu-devel] [PATCH] mux: fix ctrl-a b again Marc-André Lureau
2018-04-16 18:28 ` Peter Maydell
2018-04-16 18:44 ` Daniel P. Berrangé
2018-04-17 12:51 ` Peter Maydell
2018-04-17 18:36 ` Philippe Mathieu-Daudé
2018-04-17 20:07 ` Peter Maydell
2018-04-17 21:19 ` Peter Maydell
2018-04-17 21:33 ` Marc-André Lureau
2018-04-18 10:36 ` Marc-André Lureau
2018-04-18 10:55 ` Paolo Bonzini [this message]
2018-04-18 11:35 ` Marc-André Lureau
2018-04-18 11:55 ` Paolo Bonzini
2018-04-18 12:22 ` Marc-André Lureau
2018-04-18 13:47 ` Paolo Bonzini
2018-04-18 14:01 ` Marc-André Lureau
2018-04-18 12:06 ` Peter Maydell
2018-04-18 13:49 ` Paolo Bonzini
2018-04-18 14:32 ` Philippe Mathieu-Daudé
2018-04-18 14:38 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=860de622-d4cc-d1bf-ae27-e4d70d5d22f0@redhat.com \
--to=pbonzini@redhat.com \
--cc=berrange@redhat.com \
--cc=f4bug@amsat.org \
--cc=marcandre.lureau@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).