From: Thomas Huth <thuth@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
"QEMU Developers" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] modules-test: fix const cast
Date: Fri, 23 Aug 2019 14:11:33 +0200 [thread overview]
Message-ID: <860f2a0e-f49b-fa8d-9219-b832acaba20f@redhat.com> (raw)
In-Reply-To: <dd60f779-8349-1d0d-eb86-645e2e1b0808@redhat.com>
On 8/23/19 2:10 PM, Paolo Bonzini wrote:
> On 23/08/19 14:07, Peter Maydell wrote:
>>> Are you going to apply this and "[PATCH] modules-test: ui-spice-app is
>>> not built as module" to qemu.git directly?
>> Is the other one also needed as a build fix ?
>
> Yes, otherwise the test fails (it didn't fail in the meson tree).
>
>> I was planning to apply this one directly, yes, but I was
>> waiting to see if you and Thomas wanted to agree any change
>> to the commit message.
>
> Just "Fix build failure with --enable-modules" would be as verbose as it
> needs to be, I guess.
Fine for me.
Thomas
next prev parent reply other threads:[~2019-08-23 12:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-22 17:42 [Qemu-devel] [PATCH] modules-test: fix const cast Paolo Bonzini
2019-08-23 7:13 ` Marc-André Lureau
2019-08-23 9:06 ` Thomas Huth
2019-08-23 9:11 ` Peter Maydell
2019-08-23 12:04 ` Paolo Bonzini
2019-08-23 12:07 ` Peter Maydell
2019-08-23 12:10 ` Paolo Bonzini
2019-08-23 12:11 ` Thomas Huth [this message]
2019-08-27 12:00 ` Peter Maydell
2019-08-27 13:38 ` Marc-André Lureau
2019-08-27 14:26 ` Peter Maydell
2019-08-23 12:32 ` Miroslav Rezanina
2019-08-23 14:13 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=860f2a0e-f49b-fa8d-9219-b832acaba20f@redhat.com \
--to=thuth@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).