From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, aleksandar.qemu.devel@gmail.com,
ehabkost@redhat.com, crosa@redhat.com
Subject: Re: [PATCH 5/4] scripts/simplebench: fix python script ! headers
Date: Wed, 18 Mar 2020 23:31:26 +0100 [thread overview]
Message-ID: <8636cd05-4817-c2c4-5741-494069ba152b@redhat.com> (raw)
In-Reply-To: <20200318170226.12186-1-vsementsov@virtuozzo.com>
On 3/18/20 6:02 PM, Vladimir Sementsov-Ogievskiy wrote:
> - simplebench.py is not for executing by itself, so drop the header
> - in bench_block_job.py fix python to python3
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
> scripts/simplebench/bench_block_job.py | 2 +-
> scripts/simplebench/simplebench.py | 2 --
> 2 files changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/scripts/simplebench/bench_block_job.py b/scripts/simplebench/bench_block_job.py
> index 9808d696cf..a0dda1dc4e 100755
> --- a/scripts/simplebench/bench_block_job.py
> +++ b/scripts/simplebench/bench_block_job.py
> @@ -1,4 +1,4 @@
> -#!/usr/bin/env python
> +#!/usr/bin/env python3
> #
> # Benchmark block jobs
> #
> diff --git a/scripts/simplebench/simplebench.py b/scripts/simplebench/simplebench.py
> index 59e7314ff6..7e25f3590b 100644
> --- a/scripts/simplebench/simplebench.py
> +++ b/scripts/simplebench/simplebench.py
> @@ -1,5 +1,3 @@
> -#!/usr/bin/env python
> -#
> # Simple benchmarking framework
> #
> # Copyright (c) 2019 Virtuozzo International GmbH.
>
I'd rather see this squashed in patches 1 and 2, if not:
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
next prev parent reply other threads:[~2020-03-18 22:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-18 1:12 [PULL 0/4] Python queue for 5.0 soft freeze Eduardo Habkost
2020-03-18 1:12 ` [PULL 1/4] scripts/simplebench: add simplebench.py Eduardo Habkost
2020-03-18 1:12 ` [PULL 2/4] scripts/simplebench: add qemu/bench_block_job.py Eduardo Habkost
2020-03-18 1:12 ` [PULL 3/4] scripts/simplebench: add example usage of simplebench Eduardo Habkost
2020-03-18 1:12 ` [PULL 4/4] MAINTAINERS: add simplebench Eduardo Habkost
2020-03-18 4:12 ` [PULL 0/4] Python queue for 5.0 soft freeze no-reply
2020-03-18 7:59 ` Vladimir Sementsov-Ogievskiy
2020-03-18 16:12 ` Eduardo Habkost
2020-03-18 16:16 ` Aleksandar Markovic
2020-03-18 17:02 ` [PATCH 5/4] scripts/simplebench: fix python script ! headers Vladimir Sementsov-Ogievskiy
2020-03-18 22:31 ` Philippe Mathieu-Daudé [this message]
2020-03-20 15:59 ` [PULL 0/4] Python queue for 5.0 soft freeze Peter Maydell
2020-03-20 16:11 ` Philippe Mathieu-Daudé
2020-03-20 16:14 ` Peter Maydell
2020-03-20 16:19 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8636cd05-4817-c2c4-5741-494069ba152b@redhat.com \
--to=philmd@redhat.com \
--cc=aleksandar.qemu.devel@gmail.com \
--cc=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).