Re: [PULL 00/44] Functional test conversion, and assert(0) cleanup

[Pierrick Bouvier <pierrick.bouvier@linaro.org>]

On 9/25/24 04:09, Thomas Huth wrote:
> The following changes since commit 01dc65a3bc262ab1bec8fe89775e9bbfa627becb:
> 
>    Merge tag 'pull-target-arm-20240919' of https://git.linaro.org/people/pmaydell/qemu-arm into staging (2024-09-19 14:15:15 +0100)
> 
> are available in the Git repository at:
> 
>    https://gitlab.com/thuth/qemu.git tags/pull-request-2024-09-25
> 
> for you to fetch changes up to dc05b2628e3913e668590ba66d9c618382d351ae:
> 
>    .gitlab-ci.d: Make separate collapsible log sections for build and test (2024-09-25 09:42:06 +0200)
> 
> ----------------------------------------------------------------
> * Convert more Avocado tests to the new functional test framework
> * Clean up assert() statements, use g_assert_not_reached() when possible
> * Improve output of the gitlab CI jobs
> 
> ----------------------------------------------------------------
> Peter Maydell (2):
>        .gitlab-ci.d: Split build and test in cross build job templates
>        .gitlab-ci.d: Make separate collapsible log sections for build and test
> 
> Pierrick Bouvier (34):
>        hw/acpi: replace assert(0) with g_assert_not_reached()
>        hw/arm: replace assert(0) with g_assert_not_reached()
>        hw/net: replace assert(0) with g_assert_not_reached()
>        migration: replace assert(0) with g_assert_not_reached()
>        qobject: replace assert(0) with g_assert_not_reached()
>        target/ppc: replace assert(0) with g_assert_not_reached()
>        block: replace assert(false) with g_assert_not_reached()
>        hw/hyperv: replace assert(false) with g_assert_not_reached()
>        hw/net: replace assert(false) with g_assert_not_reached()
>        hw/nvme: replace assert(false) with g_assert_not_reached()
>        hw/pci: replace assert(false) with g_assert_not_reached()
>        hw/ppc: replace assert(false) with g_assert_not_reached()
>        migration: replace assert(false) with g_assert_not_reached()
>        target/i386/kvm: replace assert(false) with g_assert_not_reached()
>        accel/tcg: remove break after g_assert_not_reached()
>        block: remove break after g_assert_not_reached()
>        hw/acpi: remove break after g_assert_not_reached()
>        hw/net: remove break after g_assert_not_reached()
>        hw/scsi: remove break after g_assert_not_reached()
>        hw/tpm: remove break after g_assert_not_reached()
>        target/arm: remove break after g_assert_not_reached()
>        target/riscv: remove break after g_assert_not_reached()
>        fpu: remove break after g_assert_not_reached()
>        tcg/loongarch64: remove break after g_assert_not_reached()
>        include/qemu: remove return after g_assert_not_reached()
>        hw/hyperv: remove return after g_assert_not_reached()
>        hw/net: remove return after g_assert_not_reached()
>        hw/pci: remove return after g_assert_not_reached()
>        hw/ppc: remove return after g_assert_not_reached()
>        migration: remove return after g_assert_not_reached()
>        qobject: remove return after g_assert_not_reached()
>        qom: remove return after g_assert_not_reached()
>        tests/qtest: remove return after g_assert_not_reached()
>        scripts/checkpatch.pl: emit error when using assert(false)
> 
> Thomas Huth (8):
>        tests/functional/qemu_test: Add a function for launching kernels more easily
>        tests/functional: Convert the vexpressa9 Avocado test
>        tests/functional: Convert the xtensa lx60 Avocado test
>        tests/functional: Convert the SPARCStation Avocado test
>        tests/functional: Convert the e500 ppc64 Avocado test
>        tests/functional: Convert the mac ppc Avocado tests
>        tests/functional: Convert the r2d sh4 Avocado test
>        tests/functional: Convert the powernv tests from boot_linux_console.py
> 
>   MAINTAINERS                               |   7 ++
>   include/qemu/pmem.h                       |   1 -
>   accel/tcg/plugin-gen.c                    |   1 -
>   block/qcow2.c                             |   2 +-
>   block/ssh.c                               |   1 -
>   hw/acpi/aml-build.c                       |   3 +-
>   hw/arm/highbank.c                         |   2 +-
>   hw/hyperv/hyperv_testdev.c                |   7 +-
>   hw/hyperv/vmbus.c                         |  15 ++--
>   hw/net/e1000e_core.c                      |   4 +-
>   hw/net/i82596.c                           |   2 +-
>   hw/net/igb_core.c                         |   4 +-
>   hw/net/net_rx_pkt.c                       |   3 +-
>   hw/net/vmxnet3.c                          |   1 -
>   hw/nvme/ctrl.c                            |   8 +-
>   hw/pci/pci-stub.c                         |   6 +-
>   hw/ppc/ppc.c                              |   1 -
>   hw/ppc/spapr_events.c                     |   3 +-
>   hw/scsi/virtio-scsi.c                     |   1 -
>   hw/tpm/tpm_spapr.c                        |   1 -
>   migration/dirtyrate.c                     |   3 +-
>   migration/migration-hmp-cmds.c            |   2 +-
>   migration/postcopy-ram.c                  |  21 ++---
>   migration/ram.c                           |   8 +-
>   qobject/qlit.c                            |   2 +-
>   qobject/qnum.c                            |  12 +--
>   qom/object.c                              |   1 -
>   target/arm/hyp_gdbstub.c                  |   1 -
>   target/i386/kvm/kvm.c                     |   4 +-
>   target/ppc/dfp_helper.c                   |   8 +-
>   target/ppc/mmu_helper.c                   |   2 +-
>   target/riscv/monitor.c                    |   1 -
>   tests/qtest/acpi-utils.c                  |   1 -
>   fpu/softfloat-parts.c.inc                 |   2 -
>   target/riscv/insn_trans/trans_rvv.c.inc   |   2 -
>   tcg/loongarch64/tcg-target.c.inc          |   1 -
>   .gitlab-ci.d/buildtest-template.yml       |  14 +++
>   .gitlab-ci.d/buildtest.yml                |   1 +
>   .gitlab-ci.d/crossbuild-template.yml      |  48 ++++++++++-
>   scripts/checkpatch.pl                     |   4 +
>   scripts/ci/gitlab-ci-section              |  29 +++++++
>   tests/avocado/boot_linux_console.py       | 138 ------------------------------
>   tests/functional/meson.build              |  15 ++++
>   tests/functional/qemu_test/linuxkernel.py |  12 +++
>   tests/functional/test_arm_vexpress.py     |  26 ++++++
>   tests/functional/test_ppc64_e500.py       |  25 ++++++
>   tests/functional/test_ppc64_powernv.py    |  42 ++++++++-
>   tests/functional/test_ppc_mac.py          |  38 ++++++++
>   tests/functional/test_sh4_r2d.py          |  31 +++++++
>   tests/functional/test_sparc_sun4m.py      |  25 ++++++
>   tests/functional/test_xtensa_lx60.py      |  26 ++++++
>   51 files changed, 384 insertions(+), 234 deletions(-)
>   create mode 100644 scripts/ci/gitlab-ci-section
>   create mode 100755 tests/functional/test_arm_vexpress.py
>   create mode 100755 tests/functional/test_ppc64_e500.py
>   create mode 100755 tests/functional/test_ppc_mac.py
>   create mode 100755 tests/functional/test_sh4_r2d.py
>   create mode 100755 tests/functional/test_sparc_sun4m.py
>   create mode 100755 tests/functional/test_xtensa_lx60.py
> 

Thanks for pulling the assert cleanup series.