From: Jason Wang <jasowang@redhat.com>
To: Thomas Huth <thuth@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qemu-doc: Get rid of "vlan=X" example in the documentation
Date: Tue, 16 Jan 2018 14:20:00 +0800 [thread overview]
Message-ID: <8655aba8-9d63-b101-e3fc-2dbc446ec2c3@redhat.com> (raw)
In-Reply-To: <1516002017-4981-1-git-send-email-thuth@redhat.com>
On 2018年01月15日 15:40, Thomas Huth wrote:
> The vlan concept is marked as deprecated, so we should not use
> this for examples in the documentation anymore.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> qemu-options.hx | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/qemu-options.hx b/qemu-options.hx
> index 130016c..d0c8b06 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -2257,8 +2257,8 @@ qemu-system-i386 linux.img -net nic -net tap
> #launch a QEMU instance with two NICs, each one connected
> #to a TAP device
> qemu-system-i386 linux.img \
> - -net nic,vlan=0 -net tap,vlan=0,ifname=tap0 \
> - -net nic,vlan=1 -net tap,vlan=1,ifname=tap1
> + -netdev tap,id=nd0,ifname=tap0 -device e1000,netdev=nd0 \
> + -netdev tap,id=nd1,ifname=tap1 -device rtl8139,netdev=nd1
> @end example
>
> @example
Applied.
Thanks
prev parent reply other threads:[~2018-01-16 6:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-15 7:40 [Qemu-devel] [PATCH] qemu-doc: Get rid of "vlan=X" example in the documentation Thomas Huth
2018-01-16 6:20 ` Jason Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8655aba8-9d63-b101-e3fc-2dbc446ec2c3@redhat.com \
--to=jasowang@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).