* [Qemu-devel] [PATCH] Makefile: add all-user/all-linux-user/all-softmmu meta-targets
@ 2017-07-25 6:11 Philippe Mathieu-Daudé
2017-07-25 9:14 ` Peter Maydell
2017-07-25 9:49 ` Paolo Bonzini
0 siblings, 2 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2017-07-25 6:11 UTC (permalink / raw)
To: Eric Blake, Marc-André Lureau, Markus Armbruster,
Stefan Hajnoczi, Paolo Bonzini, Peter Maydell
Cc: Philippe Mathieu-Daudé, qemu-devel, qemu-trivial,
Alex Bennée, Fam Zheng
Useful to build a whole set at once.
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
Makefile | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index 5f18243d05..da899522e4 100644
--- a/Makefile
+++ b/Makefile
@@ -814,6 +814,11 @@ endif
# Dependencies in Makefile.objs files come from our recursive subdir rules
-include $(wildcard *.d tests/*.d)
+.PHONY: subdir-all-user subdir-all-linux-user subdir-all-softmmu
+subdir-all-user: $(patsubst %,subdir-%,$(filter %-user,$(TARGET_DIRS)))
+subdir-all-linux-user: $(patsubst %,subdir-%,$(filter %-linux-user,$(TARGET_DIRS)))
+subdir-all-softmmu: $(patsubst %,subdir-%,$(filter %-softmmu,$(TARGET_DIRS)))
+
include $(SRC_PATH)/tests/docker/Makefile.include
.PHONY: help
@@ -827,7 +832,7 @@ help:
@echo ''
@$(if $(TARGET_DIRS), \
echo 'Architecture specific targets:'; \
- $(foreach t, $(TARGET_DIRS), \
+ $(foreach t, $(TARGET_DIRS) all-user all-linux-user all-softmmu, \
printf " %-30s - Build for %s\\n" $(patsubst %,subdir-%,$(t)) $(t);) \
echo '')
@echo 'Cleaning targets:'
--
2.13.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] Makefile: add all-user/all-linux-user/all-softmmu meta-targets
2017-07-25 6:11 [Qemu-devel] [PATCH] Makefile: add all-user/all-linux-user/all-softmmu meta-targets Philippe Mathieu-Daudé
@ 2017-07-25 9:14 ` Peter Maydell
2017-07-25 9:49 ` Paolo Bonzini
1 sibling, 0 replies; 4+ messages in thread
From: Peter Maydell @ 2017-07-25 9:14 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: Eric Blake, Marc-André Lureau, Markus Armbruster,
Stefan Hajnoczi, Paolo Bonzini, QEMU Developers, QEMU Trivial,
Alex Bennée, Fam Zheng
On 25 July 2017 at 07:11, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
> Useful to build a whole set at once.
You can already do this by not specifying a --target-list=
option and using whichever of --disable-system and
--disable-user you need to skip the ones you don't want,
can't you?
thanks
-- PMM
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] Makefile: add all-user/all-linux-user/all-softmmu meta-targets
2017-07-25 6:11 [Qemu-devel] [PATCH] Makefile: add all-user/all-linux-user/all-softmmu meta-targets Philippe Mathieu-Daudé
2017-07-25 9:14 ` Peter Maydell
@ 2017-07-25 9:49 ` Paolo Bonzini
2017-07-25 18:39 ` Philippe Mathieu-Daudé
1 sibling, 1 reply; 4+ messages in thread
From: Paolo Bonzini @ 2017-07-25 9:49 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, Eric Blake, Marc-André Lureau,
Markus Armbruster, Stefan Hajnoczi, Peter Maydell
Cc: qemu-devel, qemu-trivial, Alex Bennée, Fam Zheng
On 25/07/2017 08:11, Philippe Mathieu-Daudé wrote:
> Useful to build a whole set at once.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> Makefile | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 5f18243d05..da899522e4 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -814,6 +814,11 @@ endif
> # Dependencies in Makefile.objs files come from our recursive subdir rules
> -include $(wildcard *.d tests/*.d)
>
> +.PHONY: subdir-all-user subdir-all-linux-user subdir-all-softmmu
> +subdir-all-user: $(patsubst %,subdir-%,$(filter %-user,$(TARGET_DIRS)))
> +subdir-all-linux-user: $(patsubst %,subdir-%,$(filter %-linux-user,$(TARGET_DIRS)))
> +subdir-all-softmmu: $(patsubst %,subdir-%,$(filter %-softmmu,$(TARGET_DIRS)))
I'm not sure why you need subdir-all-linux-user. I think it's okay to
add these, but please add "romsubdir-all" too. This way "all" can use
"subdir-all-user subdir-all-softmmu romsubdir-all" and you can remove
"recurse-all".
Paolo
> include $(SRC_PATH)/tests/docker/Makefile.include
>
> .PHONY: help
> @@ -827,7 +832,7 @@ help:
> @echo ''
> @$(if $(TARGET_DIRS), \
> echo 'Architecture specific targets:'; \
> - $(foreach t, $(TARGET_DIRS), \
> + $(foreach t, $(TARGET_DIRS) all-user all-linux-user all-softmmu, \
> printf " %-30s - Build for %s\\n" $(patsubst %,subdir-%,$(t)) $(t);) \
> echo '')
> @echo 'Cleaning targets:'
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] Makefile: add all-user/all-linux-user/all-softmmu meta-targets
2017-07-25 9:49 ` Paolo Bonzini
@ 2017-07-25 18:39 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2017-07-25 18:39 UTC (permalink / raw)
To: Paolo Bonzini, Eric Blake, Marc-André Lureau,
Markus Armbruster, Stefan Hajnoczi, Peter Maydell
Cc: qemu-devel, qemu-trivial, Alex Bennée, Fam Zheng
On 07/25/2017 06:49 AM, Paolo Bonzini wrote:
> On 25/07/2017 08:11, Philippe Mathieu-Daudé wrote:
>> Useful to build a whole set at once.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> ---
>> Makefile | 7 ++++++-
>> 1 file changed, 6 insertions(+), 1 deletion(-)
>>
>> diff --git a/Makefile b/Makefile
>> index 5f18243d05..da899522e4 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -814,6 +814,11 @@ endif
>> # Dependencies in Makefile.objs files come from our recursive subdir rules
>> -include $(wildcard *.d tests/*.d)
>>
>> +.PHONY: subdir-all-user subdir-all-linux-user subdir-all-softmmu
>> +subdir-all-user: $(patsubst %,subdir-%,$(filter %-user,$(TARGET_DIRS)))
>> +subdir-all-linux-user: $(patsubst %,subdir-%,$(filter %-linux-user,$(TARGET_DIRS)))
>> +subdir-all-softmmu: $(patsubst %,subdir-%,$(filter %-softmmu,$(TARGET_DIRS)))
>
> I'm not sure why you need subdir-all-linux-user. I think it's okay to
Indeed, subdir-all-user is enough.
> add these, but please add "romsubdir-all" too. This way "all" can use
> "subdir-all-user subdir-all-softmmu romsubdir-all" and you can remove
> "recurse-all".
Ok.
>
> Paolo
>
>> include $(SRC_PATH)/tests/docker/Makefile.include
>>
>> .PHONY: help
>> @@ -827,7 +832,7 @@ help:
>> @echo ''
>> @$(if $(TARGET_DIRS), \
>> echo 'Architecture specific targets:'; \
>> - $(foreach t, $(TARGET_DIRS), \
>> + $(foreach t, $(TARGET_DIRS) all-user all-linux-user all-softmmu, \
>> printf " %-30s - Build for %s\\n" $(patsubst %,subdir-%,$(t)) $(t);) \
>> echo '')
>> @echo 'Cleaning targets:'
>>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-07-25 18:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-25 6:11 [Qemu-devel] [PATCH] Makefile: add all-user/all-linux-user/all-softmmu meta-targets Philippe Mathieu-Daudé
2017-07-25 9:14 ` Peter Maydell
2017-07-25 9:49 ` Paolo Bonzini
2017-07-25 18:39 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).