From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
Sergio Lopez <slp@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>,
Eduardo Habkost <eduardo@habkost.net>,
qemu-ppc@nongnu.org,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
Subject: Re: [PATCH 1/5] hw/timer/hpet: Include missing 'hw/qdev-properties.h' header
Date: Wed, 15 Feb 2023 08:55:40 -1000 [thread overview]
Message-ID: <8665b6e1-d962-c9d6-76e1-0967974c370e@linaro.org> (raw)
In-Reply-To: <20230215174353.37097-2-philmd@linaro.org>
On 2/15/23 07:43, Philippe Mathieu-Daudé wrote:
> Avoid when refactoring unrelated headers:
>
> hw/timer/hpet.c:776:39: error: array has incomplete element type 'Property' (aka 'struct Property')
> static Property hpet_device_properties[] = {
> ^
> hw/timer/hpet.c:777:5: error: implicit declaration of function 'DEFINE_PROP_UINT8' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
> DEFINE_PROP_UINT8("timers", HPETState, num_timers, HPET_MIN_TIMERS),
> ^
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> hw/timer/hpet.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/timer/hpet.c b/hw/timer/hpet.c
> index 9520471be2..214d6a0501 100644
> --- a/hw/timer/hpet.c
> +++ b/hw/timer/hpet.c
> @@ -30,6 +30,7 @@
> #include "qapi/error.h"
> #include "qemu/error-report.h"
> #include "qemu/timer.h"
> +#include "hw/qdev-properties.h"
> #include "hw/timer/hpet.h"
> #include "hw/sysbus.h"
> #include "hw/rtc/mc146818rtc.h"
Acked-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2023-02-15 18:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-15 17:43 [PATCH 0/5] hw/timer/i8254: Un-inline and simplify IRQs Philippe Mathieu-Daudé
2023-02-15 17:43 ` [PATCH 1/5] hw/timer/hpet: Include missing 'hw/qdev-properties.h' header Philippe Mathieu-Daudé
2023-02-15 18:55 ` Richard Henderson [this message]
2023-02-15 17:43 ` [PATCH 2/5] hw/timer/i8254: Factor i8254_pit_create() out and document Philippe Mathieu-Daudé
2023-02-15 18:56 ` Richard Henderson
2023-02-15 17:43 ` [PATCH 3/5] hw/i386/pc: Un-inline i8254_pit_init() Philippe Mathieu-Daudé
2023-02-15 18:58 ` Richard Henderson
2023-02-15 17:43 ` [PATCH 4/5] hw/timer/i8254: Really inline i8254_pit_init() Philippe Mathieu-Daudé
2023-02-15 19:00 ` Richard Henderson
2023-02-15 17:43 ` [PATCH 5/5] hw/i386/kvm: Factor i8254_pit_create_try_kvm() out Philippe Mathieu-Daudé
2023-02-15 19:02 ` Richard Henderson
2023-03-01 21:54 ` [PATCH 0/5] hw/timer/i8254: Un-inline and simplify IRQs Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8665b6e1-d962-c9d6-76e1-0967974c370e@linaro.org \
--to=richard.henderson@linaro.org \
--cc=eduardo@habkost.net \
--cc=kvm@vger.kernel.org \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=slp@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).